vh/forgefirm
1
0
Fork 0
mirror of https://github.com/openglow-org/forgefirm.git synced 2026-09-27 08:41:13 -07:00
Code Issues Packages Projects Releases Wiki Activity

exthost.package-routes: the panel page carries the card, and its script is in order

Browse Source 
The page the image serves must hold the card (extpkgs, extswitch, extfile,
extstaged, extinstallphrase, extAct, loadExt) and must define loadExt
before the call that runs while panel.js parses. That second check is the
bug the browser found: ext.js loaded after panel.js is an undefined
loadExt, and it takes the rest of the System tab's loads down with it.

Proven. The unit suite: 451 tests, 0 undefined names. On the bench
reference, image 20260921154037 with the cross-built forgectrl mounted over
the image's: PASS. Against a forgectrl built with the scripts in the old
order the order check FAILS, as it should.

Acceptance. exthost.package-routes gains forgectrl's src/ui/ext.js,
src/ui/index.html, and src/ui/embed.cmake in its covers map.
This commit is contained in:
ScottW514
2026-09-21 12:13:39 -04:00
parent 9c36df9ee9
commit 963bded9b3
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
forgetest/forgetest/suite/exthost.py
+16 -2
View File
@@ -1250,7 +1250,8 @@ def hold_pause_tier(ctx):
@test("exthost.package-routes", title="The panel's package routes are the extension host's own word",
subsystem="exthost", kind="auto", est_min=2,
covers=[("forgectrl", "src/extpkg.*"), ("forgectrl", "src/main.c"), ("forgeext", "src/main.c"),
covers=[("forgectrl", "src/extpkg.*"), ("forgectrl", "src/main.c"), ("forgectrl", "src/ui/ext.js"),
("forgectrl", "src/ui/index.html"), ("forgectrl", "src/ui/embed.cmake"), ("forgeext", "src/main.c"),
("forgeext", "src/install.*"), ("forgeext", "src/state.*")],
requires=["exthost.service", "forgectrl.auth"],
description="Extensions stay as found (the package is installed and never runs). The reference package is "
@@ -1261,7 +1262,9 @@ def hold_pause_tier(ctx):
"required-holds and the list says required; disable and enable change the host's state "
"file; an action outside the closed list and an id that has not the form of one are 400 "
"and run nothing; an id that is not installed is 409 in the host's words; without the "
"login 403; remove takes the package, its data, and its name away. The key and the work "
"login 403; remove takes the package, its data, and its name away. The panel page carries "
"the card and its script, and the script is in the page before the one that calls it "
"(the panel runs its tab's loads while it parses). The key and the work "
"directory are removed and the extension root is as found.")
def package_routes(ctx):
import shutil
@@ -1286,6 +1289,17 @@ def package_routes(ctx):
return json.loads(_read(EXT_ROOT + "/state.json") or "{}").get("packages", {}).get(REF_ID, {})
try:
# The card is in the page the image serves, and its script is loaded before the one whose
# tab loads call it: panel.js runs them while it parses, so a later ext.js is a broken tab.
st, page = fc.get("/", raw=True)
text = page.decode("utf-8", "replace") if isinstance(page, bytes) else str(page)
ev["panel_page_bytes"] = len(text)
ctx.check(st == 200 and text, "GET / -> %s", st)
for want in ("extpkgs", "extswitch", "extfile", "extstaged", "extinstallphrase", "extAct", "loadExt"):
ctx.check(want in text, "the panel page carries no %s", want)
ctx.check(0 < text.index("function loadExt") < text.index("loadExt();"),
"the panel page defines loadExt after the call that runs at parse time")
archive, pub = _pack_reference(work, lan_ip(), more_caps=["hold"])
shutil.copy(pub, owner_key)
os.chmod(owner_key, 0o644)