NMAPDEV plugin work v0.6 #645 🆕🔎

docker-compose.yml

@@ -11,12 +11,10 @@ services:
     network_mode: host
     # restart: unless-stopped
     volumes:
-      # - ${APP_DATA_LOCATION}/netalertx_dev/config:/app/config
-      - ${APP_DATA_LOCATION}/netalertx/config:/app/config
-      # - ${APP_DATA_LOCATION}/netalertx/config:/home/pi/pialert/config
-      # - ${APP_DATA_LOCATION}/netalertx_dev/db:/app/db      
-      - ${APP_DATA_LOCATION}/netalertx/db:/app/db           
-      # - ${APP_DATA_LOCATION}/netalertx/db:/home/pi/pialert/db 
+      - ${APP_DATA_LOCATION}/netalertx_dev/config:/app/config
+      # - ${APP_DATA_LOCATION}/netalertx/config:/app/config
+      - ${APP_DATA_LOCATION}/netalertx_dev/db:/app/db      
+      # - ${APP_DATA_LOCATION}/netalertx/db:/app/db           
       # (optional) useful for debugging if you have issues setting up the container
       # - ${LOGS_LOCATION}:/app/front/log      
       # ---------------------------------------------------------------------------

docs/NOTIFICATIONS.md

@@ -8,7 +8,7 @@ There are 3 ways how to influence notifications:
 4. Ignoring devices
 
 > [!NOTE]
-> It's recommended to use the same schedule interval for all plugins responsible for scanning devices, otherwise false positives might be reported if different devices are discovered by different plugins. Check the Settings > Enabled plugins section for a warning:
+> It's recommended to use the same schedule interval for all plugins responsible for scanning devices, otherwise false positives might be reported if different devices are discovered by different plugins. Check the **Settings** > **Enabled settings** section for a warning:
 > ![Schedules out-of-sync](/docs/img/NOTIFICATIONS/Schedules_out-of-sync.png)
 
 
@@ -36,7 +36,7 @@ On almost all plugins there are 2 core settings, `<plugin>_WATCH` and `<plugin>_
 
 ![Global notification settings](/docs/img/NOTIFICATIONS/Global-notification-settings.png)
 
-In the Notification Processing section, you can specify blanket rules. These allso to specify exceptions to the Plugin and Device settings and will override those.
+In the Notification Processing section, you can specify blanket rules. These allow you to specify exceptions to the Plugin and Device settings and will override those.
 
 1. Notify on (`NTFPRCS_INCLUDED_SECTIONS`) allows you to specify which events trigegr notifications. Usual setups will have `new_devices`, `down_devices`, and possibly `events` set. Setting `plugin` might be too noisy for most setups.
 2. Alert down after (`NTFPRCS_alert_down_time`) is useful if you want to wait for some time before the system sends out a down notification for a device. This is related to the on-device **Alert down** setting.

front/plugins/nmap_dev_scan/config.json

@@ -300,7 +300,7 @@
     {
       "function": "ARGS",
       "type": "text",
-      "default_value": "sudo nmap -sn ",
+      "default_value": "sudo nmap -sn -PR -n ",
       "options": [],
       "localized": [
         "name",
@@ -315,7 +315,7 @@
       "description": [
         {
           "language_code": "en_us",
-          "string": "Arguments to run nmap-scan with. Recommended and tested only with the setting: <br/> <code>sudo nmap -sn </code>."
+          "string": "Arguments to run nmap-scan with. Recommended and tested only with the setting: <br/> <code>sudo nmap -sn </code>. <br/><br/> Note: The plugin attaches the interface and network mask, for example <code> -e eth1 192.168.1.0/24</code> and performs a separate scan for each interface specified in the <a onclick=\"toggleAllSettings()\" href=\"#SCAN_SUBNETS\"><code>SCAN_SUBNETS</code> setting</a>."
         }
       ]
     }

front/plugins/nmap_dev_scan/nmap_dev.py

@@ -83,9 +83,10 @@ def execute_scan (subnets_list, timeout):
     devices_list = []
 
     # scan each interface
-
     for interface in subnets_list:
+
         nmap_output = execute_scan_on_interface(interface, timeout)
+
         mylog('verbose', [f'[{pluginName}] nmap_output: ', nmap_output])
 
         if nmap_output is not None:
@@ -124,7 +125,7 @@ def execute_scan (subnets_list, timeout):
 
 def execute_scan_on_interface (interface, timeout):
     # Prepare command arguments
-    scan_args = get_setting_value('NMAPDEV_ARGS').split() + [interface.split()[0]] 
+    scan_args = get_setting_value('NMAPDEV_ARGS').split() + interface.replace('--interface=','-e ').split()
 
     mylog('verbose', [f'[{pluginName}] scan_args: ', scan_args])   
 

front/plugins/nslookup_scan/config.json

@@ -54,7 +54,7 @@
       }],
       "description": [{
           "language_code":"en_us",
-          "string" : "When the plugin should be executed. If enabled this will execute the scan until there are no <code>(unknown)</code> or <code>(name not found)</code> devices. Setting this to <code>on_new_device</code> or a daily <code>schedule</code> is recommended."
+          "string" : "When the plugin should be executed. If enabled this will execute the scan until there are no <code>(unknown)</code> or <code>(name not found)</code> devices. Setting this to <code>on_new_device</code> or a daily <code>schedule</code> is recommended.<br/><br/> Depends on the <a onclick=\"toggleAllSettings()\" href=\"#SCAN_SUBNETS\"><code>SCAN_SUBNETS</code> setting</a>."
       }]
   },    
     {
@@ -112,7 +112,7 @@
       }],
       "description": [{
           "language_code":"en_us",
-          "string" : "Only enabled if you select <code>schedule</code> in the <a href=\"#NSLOOKUP_RUN\"><code>NSLOOKUP_RUN</code> setting</a>. Make sure you enter the schedule in the correct cron-like format (e.g. validate at <a href=\"https://crontab.guru/\" target=\"_blank\">crontab.guru</a>). For example entering <code>0 4 * * *</code> will run the scan after 4 am in the <a onclick=\"toggleAllSettings()\" href=\"#TIMEZONE\"><code>TIMEZONE</code> you set above</a>. Will be run NEXT time the time passes.<br/><br/> Depends on the <a onclick=\"toggleAllSettings()\" href=\"#SCAN_SUBNETS\"><code>SCAN_SUBNETS</code> setting</a>."
+          "string" : "Only enabled if you select <code>schedule</code> in the <a href=\"#NSLOOKUP_RUN\"><code>NSLOOKUP_RUN</code> setting</a>. Make sure you enter the schedule in the correct cron-like format (e.g. validate at <a href=\"https://crontab.guru/\" target=\"_blank\">crontab.guru</a>). For example entering <code>0 4 * * *</code> will run the scan after 4 am in the <a onclick=\"toggleAllSettings()\" href=\"#TIMEZONE\"><code>TIMEZONE</code> you set above</a>. Will be run NEXT time the time passes."
       },
       {
           "language_code":"es_es",