Comprehensive design for incremental refactoring of the 13k-line
FileTransferActivity god-struct using a unified Pane abstraction.
Detailed step-by-step plan covering 6 phases: split monoliths,
error handling, Pane struct, action dedup, session split, view reorg.
Extract 26 popup components from the monolithic 1,868-line popups.rs
into 20 individual files under popups/. Each file contains one or two
related components with their own imports. The popups.rs module file
now contains only module declarations and re-exports.
Replace 8 panic!() calls with error!() logging and early returns/fallthrough.
These panics documented invariants (e.g. "this tab can't do X") but would crash
the app if somehow triggered. Error logging is safer and more resilient.
Replace raw FileExplorer fields in Browser with Pane structs that bundle
the explorer and connected state. Move host_bridge_connected and
remote_connected from FileTransferActivity into the panes. Add navigation
API (fs_pane, opposite_pane, is_find_tab) for future unification tasks.
Rename private get_selected_file to get_selected_file_by_id and add three
new unified methods (get_selected_entries, get_selected_file, is_selected_one)
that dispatch based on self.browser.tab(). Old per-tab methods are kept for
now until their callers are migrated in subsequent tasks.
Collapse _local_/_remote_ action method pairs (mkdir, delete, symlink,
chmod, rename, copy) into unified methods that branch internally on
is_local_tab(). This halves the number of action methods and simplifies
the update.rs dispatch logic. Also unifies ShowFileInfoPopup and
ShowChmodPopup dispatching to use get_selected_entries().
Move `host_bridge` and `client` filesystem fields from FileTransferActivity
into the Pane struct, enabling tab-agnostic dispatch via `fs_pane()`/
`fs_pane_mut()`. This eliminates most `is_local_tab()` branching across
15+ action files.
Key changes:
- Add `fs: Box<dyn HostBridge>` to Pane, remove from FileTransferActivity
- Replace per-side method pairs with unified pane-dispatched methods
- Unify navigation (changedir, reload, scan, file_exists, has_file_changed)
- Replace 147-line popup if/else chain with data-driven priority table
- Replace assert!/panic!/unreachable! with proper error handling
- Fix typo "filetransfer_activiy" across ~29 files
- Add unit tests for Pane
Net result: -473 lines, single code path for most file operations.
Use containers to test file transfers
Container setup
Container setup
tests with docker-compose
these tests won't work with containers
ftp tests with containers; removed crap servers; tests only lib
hostname for github
booooooh
fixed recursive remove FTP
Use containers to test file transfers
Container setup
Container setup
tests with docker-compose
these tests won't work with containers
ftp tests with containers; removed crap servers; tests only lib
hostname for github
booooooh
fixed recursive remove FTP
fixed rename
changelog
Desperate attempt
Fixed ftp tests; migrated sftp tests to containers; use env for services
github actions are just broken imo
github actions are just broken imo
Don't use services, since they just don't fuckin work...
docker compose not supported yet?
deprecated typo
Now explain this: github actions have services (which don't work) and then you find out docker-compose is already installed *BLOWMIND*
Fixed hostname for tests
scp tests
maybe
tests
wtf
Restored host tests
Changelog
Improving coverage
Improving coverage
Restored coverage task
More tests for file transfers; test ssh keys too
typo
tests; code improvements
Use tests helpers
fixed tempdir
fixed tempdir
Christian Visintin
veeso