vh/rest-server
1
0
Fork 0
mirror of https://github.com/restic/rest-server.git synced 2026-09-26 14:01:21 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

make deleting idempotent

Browse Source
This commit is contained in:
Michael Eischer
2022-09-02 23:32:52 +02:00
parent b562edefd1
commit a8fdca3b9f
2 changed files with 93 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
repo/repo.go
+10 -2
View File
@@ -325,7 +325,11 @@ func (h *Handler) deleteConfig(w http.ResponseWriter, r *http.Request) {
cfg := h.getSubPath("config")
if err := os.Remove(cfg); err != nil {
h.fileAccessError(w, err)
// ignore not exist errors to make deleting idempotent, which is
// necessary to properly handle request retries
if !errors.Is(err, os.ErrNotExist) {
h.fileAccessError(w, err)
}
return
}
}
@@ -690,7 +694,11 @@ func (h *Handler) deleteBlob(w http.ResponseWriter, r *http.Request) {
}
if err := os.Remove(path); err != nil {
h.fileAccessError(w, err)
// ignore not exist errors to make deleting idempotent, which is
// necessary to properly handle request retries
if !errors.Is(err, os.ErrNotExist) {
h.fileAccessError(w, err)
}
return
}