Volva code-review surfaced 5 findings against the TDD-passing
implementation; all 5 addressed.
Drift fixes (code):
- Add `assert argv is None or all(isinstance(a, str) for a in argv)`
at both `main` and `_parse_args` entry points (PRE-001 was unenforced).
- `main` now catches `SystemExit` and returns `exc.code` verbatim —
argparse's --help (SystemExit(0)) was escaping through main as an
unhandled exception. Contract amended in-place to spell out the
SystemExit-from-argparse-clean-exits passthrough in both
`main` and `_parse_args` ERROR_ROUTING. New `help_exits_cleanly`
test added per the contract amendment.
- Add the PRE-001 union-type assert at `_render_event` entry —
unmatched Event variants would have silently no-op'd.
- `_run_turn` now awaits `cancel_task` in the `finally` block before
returning. Under fast-stream + slow-cancel scenarios the
`[cancel_failed]` line could miss being written before _run_turn
returns, AND _amain could close the AsyncClient while the cancel
POST was still in flight. `_cancel_and_log` swallows all errors
per INV-009 so the await is safe.
Test gap fix:
- New `_FlushCountingIO` subclass counts flush() calls;
`test_text_to_stdout_only` and `test_done_writes_newline_and_label`
now assert `flush_count == 1` to verify INV-010 (per-chunk flush).
Previously the tests would have passed even with flush removed.
Meta-note carried in persistent-memory: TDD caught central behavior
(stdout/stderr routing, exit-code mapping, create-session ordering,
SIGINT idempotence); the cross-model code review consistently catches
assert-boundary + observability-shape gaps across all three issues
(#1: 4 findings, #2: 3 findings, #3: 5 findings).
118/118 tests GREEN; ruff clean; drift check clean.
vh
9717fb80e2