feat(#6): startup session picker for bare TUI mode
v1 coverage-audit slice b2. The audit found list_sessions had no caller — the startup session picker (design-brief §4) was never built; bare TUI mode was a hard usage error. Add SessionPickerApp (mirrors AgentPickerApp) and resolve bare mode in _resolve_then_run. - Bare TUI mode (no --session/--new) now valid → session picker. Resolution: 0 sessions -> [no_sessions] exit 14 (resume-only per §4 "no in-app creation, --new only"); exactly 1 -> auto-resume (§4 "picker only when >1"); >=2 -> SessionPickerApp -> resume pick (Esc/Ctrl-D -> exit 0). - cli._parse: bare TUI valid; --send still requires one flag; --agent forbidden in bare mode. run_tui PRE-002 xor -> mutually-exclusive. - Contract #6 amended (SessionPickerApp + bare-mode resolution) + validated. TDD: 3 picker pilot tests + 5 resolution tests + 3 cli validation tests. Suite 528 green; touched code ruff-clean. Design note: bare + 0 sessions errors (honors §4's no-in-app-creation clause); the friendlier auto-fall-through-to-new is deferred pending operator preference.
This commit is contained in:
@@ -2945,3 +2945,225 @@ class TestTuiBifrostBind:
|
||||
err = capsys.readouterr().err
|
||||
assert "bifrost: status=bound" in err
|
||||
assert "plane=memory" in err
|
||||
|
||||
|
||||
class TestSessionPickerApp:
|
||||
"""docs/contracts/issues/6.contract.md FN SessionPickerApp (amendment slice b2)."""
|
||||
|
||||
@staticmethod
|
||||
def _two():
|
||||
from ratatoskr.sessions import SessionInfo
|
||||
|
||||
return [
|
||||
SessionInfo(
|
||||
session_id="s-first-0001", agent_id="mimir", created_at="t0",
|
||||
last_active="t1", metadata={}, message_count=3, name=None,
|
||||
archived=False, tags=[],
|
||||
),
|
||||
SessionInfo(
|
||||
session_id="s-second-002", agent_id="echo", created_at="t0",
|
||||
last_active="t2", metadata={}, message_count=None, name="probe",
|
||||
archived=False, tags=[],
|
||||
),
|
||||
]
|
||||
|
||||
def test_pick_returns_session_id(self) -> None:
|
||||
"""pick_returns_session_id [happy,tracer]: idx 1 + Enter → exit value == that session_id."""
|
||||
from ratatoskr.tui import SessionPickerApp
|
||||
|
||||
app = SessionPickerApp(self._two())
|
||||
|
||||
async def drive() -> str | None:
|
||||
async with app.run_test() as pilot:
|
||||
from textual.widgets import ListView
|
||||
|
||||
lv = app.query_one("#session-list", ListView)
|
||||
lv.index = 1
|
||||
await pilot.pause()
|
||||
await pilot.press("enter")
|
||||
await pilot.pause()
|
||||
return app.return_value
|
||||
|
||||
import asyncio
|
||||
|
||||
assert asyncio.run(drive()) == "s-second-002"
|
||||
|
||||
def test_esc_returns_none(self) -> None:
|
||||
"""esc_returns_none [happy]: Esc → exit value is None (dismiss, resume nothing)."""
|
||||
from ratatoskr.tui import SessionPickerApp
|
||||
|
||||
app = SessionPickerApp(self._two())
|
||||
|
||||
async def drive() -> str | None:
|
||||
async with app.run_test() as pilot:
|
||||
await pilot.press("escape")
|
||||
await pilot.pause()
|
||||
return app.return_value
|
||||
|
||||
import asyncio
|
||||
|
||||
assert asyncio.run(drive()) is None
|
||||
|
||||
def test_ctrl_d_returns_none(self) -> None:
|
||||
"""ctrl_d_returns_none [adversarial]: Ctrl-D → None."""
|
||||
from ratatoskr.tui import SessionPickerApp
|
||||
|
||||
app = SessionPickerApp(self._two())
|
||||
|
||||
async def drive() -> str | None:
|
||||
async with app.run_test() as pilot:
|
||||
await pilot.press("ctrl+d")
|
||||
await pilot.pause()
|
||||
return app.return_value
|
||||
|
||||
import asyncio
|
||||
|
||||
assert asyncio.run(drive()) is None
|
||||
|
||||
|
||||
class TestBareSessionPicker:
|
||||
"""docs/contracts/issues/6.contract.md amendment (slice b2): _resolve_then_run bare mode."""
|
||||
|
||||
@staticmethod
|
||||
def _bare_args() -> ParsedArgs:
|
||||
return ParsedArgs(
|
||||
send_content=None, session_id=None, new=False, agent_id=None,
|
||||
api_key="k", server_url="https://w.example", raw=False,
|
||||
end_user_id=None, bifrost=None, bifrost_plane=None, consumer_key=None,
|
||||
)
|
||||
|
||||
@staticmethod
|
||||
def _sess(sid: str, agent: str = "mimir"):
|
||||
from ratatoskr.sessions import SessionInfo
|
||||
|
||||
return SessionInfo(
|
||||
session_id=sid, agent_id=agent, created_at="t0", last_active="t1",
|
||||
metadata={}, message_count=1, name=None, archived=False, tags=[],
|
||||
)
|
||||
|
||||
def test_bare_zero_sessions_errors(
|
||||
self, monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
|
||||
) -> None:
|
||||
"""bare_zero_sessions_errors [error]: 0 sessions → exit 14 [no_sessions]; App not opened."""
|
||||
import ratatoskr.tui as tui_mod
|
||||
from ratatoskr.sessions import SessionPage
|
||||
|
||||
async def fake_list(client, **kw):
|
||||
return SessionPage(items=[], next_cursor=None)
|
||||
|
||||
monkeypatch.setattr(tui_mod, "list_sessions", fake_list)
|
||||
opened: list[int] = []
|
||||
|
||||
async def spy(self, *a, **k):
|
||||
opened.append(1)
|
||||
return 0
|
||||
|
||||
monkeypatch.setattr(RatatoskrApp, "run_async", spy)
|
||||
rc = run_tui(self._bare_args())
|
||||
assert rc == 14
|
||||
assert "[no_sessions]" in capsys.readouterr().err
|
||||
assert not opened
|
||||
|
||||
def test_bare_one_session_auto_resumes(self, monkeypatch: pytest.MonkeyPatch) -> None:
|
||||
"""bare_one_session_auto_resumes: exactly 1 → auto-resume, no picker (§4 >1 rule)."""
|
||||
import ratatoskr.tui as tui_mod
|
||||
from ratatoskr.sessions import SessionPage
|
||||
from ratatoskr.tui import SessionPickerApp
|
||||
|
||||
async def fake_list(client, **kw):
|
||||
return SessionPage(items=[self._sess("s-solo")], next_cursor=None)
|
||||
|
||||
monkeypatch.setattr(tui_mod, "list_sessions", fake_list)
|
||||
picker_used: list[int] = []
|
||||
|
||||
async def spy_picker(self, *a, **k):
|
||||
picker_used.append(1)
|
||||
return None
|
||||
|
||||
monkeypatch.setattr(SessionPickerApp, "run_async", spy_picker)
|
||||
snap: dict = {}
|
||||
|
||||
async def cap(self, *a, **k):
|
||||
snap["sid"] = self.session_id
|
||||
return 0
|
||||
|
||||
monkeypatch.setattr(RatatoskrApp, "run_async", cap)
|
||||
rc = run_tui(self._bare_args())
|
||||
assert rc == 0
|
||||
assert snap["sid"] == "s-solo"
|
||||
assert not picker_used
|
||||
|
||||
def test_bare_multi_opens_picker(self, monkeypatch: pytest.MonkeyPatch) -> None:
|
||||
"""bare_multi_opens_picker [scenario,tracer]: >1 → picker; its choice resumes."""
|
||||
import ratatoskr.tui as tui_mod
|
||||
from ratatoskr.sessions import SessionPage
|
||||
from ratatoskr.tui import SessionPickerApp
|
||||
|
||||
async def fake_list(client, **kw):
|
||||
return SessionPage(items=[self._sess("s-a"), self._sess("s-b")], next_cursor=None)
|
||||
|
||||
monkeypatch.setattr(tui_mod, "list_sessions", fake_list)
|
||||
|
||||
async def pick_b(self, *a, **k):
|
||||
return "s-b"
|
||||
|
||||
monkeypatch.setattr(SessionPickerApp, "run_async", pick_b)
|
||||
snap: dict = {}
|
||||
|
||||
async def cap(self, *a, **k):
|
||||
snap["sid"] = self.session_id
|
||||
return 0
|
||||
|
||||
monkeypatch.setattr(RatatoskrApp, "run_async", cap)
|
||||
rc = run_tui(self._bare_args())
|
||||
assert rc == 0
|
||||
assert snap["sid"] == "s-b"
|
||||
|
||||
def test_bare_picker_dismiss_exits_zero(self, monkeypatch: pytest.MonkeyPatch) -> None:
|
||||
"""bare_picker_dismiss_exits_zero [scenario]: picker None → exit 0; App not opened."""
|
||||
import ratatoskr.tui as tui_mod
|
||||
from ratatoskr.sessions import SessionPage
|
||||
from ratatoskr.tui import SessionPickerApp
|
||||
|
||||
async def fake_list(client, **kw):
|
||||
return SessionPage(items=[self._sess("s-a"), self._sess("s-b")], next_cursor=None)
|
||||
|
||||
monkeypatch.setattr(tui_mod, "list_sessions", fake_list)
|
||||
|
||||
async def pick_none(self, *a, **k):
|
||||
return None
|
||||
|
||||
monkeypatch.setattr(SessionPickerApp, "run_async", pick_none)
|
||||
opened: list[int] = []
|
||||
|
||||
async def spy(self, *a, **k):
|
||||
opened.append(1)
|
||||
return 0
|
||||
|
||||
monkeypatch.setattr(RatatoskrApp, "run_async", spy)
|
||||
rc = run_tui(self._bare_args())
|
||||
assert rc == 0
|
||||
assert not opened
|
||||
|
||||
def test_bare_list_sessions_api_failure(
|
||||
self, monkeypatch: pytest.MonkeyPatch, capsys: pytest.CaptureFixture[str]
|
||||
) -> None:
|
||||
"""bare_list_sessions_api_failure [error]: list_sessions 500 → exit 20; App not opened."""
|
||||
import ratatoskr.tui as tui_mod
|
||||
from ratatoskr.sessions import SessionApiFailed
|
||||
|
||||
async def fake_list(client, **kw):
|
||||
raise SessionApiFailed(status=500, body=b"boom")
|
||||
|
||||
monkeypatch.setattr(tui_mod, "list_sessions", fake_list)
|
||||
opened: list[int] = []
|
||||
|
||||
async def spy(self, *a, **k):
|
||||
opened.append(1)
|
||||
return 0
|
||||
|
||||
monkeypatch.setattr(RatatoskrApp, "run_async", spy)
|
||||
rc = run_tui(self._bare_args())
|
||||
assert rc == 20
|
||||
assert "[session_api_failed]" in capsys.readouterr().err
|
||||
assert not opened
|
||||
|
||||
Reference in New Issue
Block a user