Fix: re-enable global lint, fix un-caught warnings / errors (#6990)

This commit is contained in:
shamoon
2026-08-15 11:01:29 -07:00
committed by GitHub
parent 342afa2215
commit f711d290a7
22 changed files with 32 additions and 41 deletions
+7 -5
View File
@@ -16,14 +16,16 @@ export default function Component({ service }) {
widget.fields = widget.fields.slice(0, MAX_FIELDS);
}
if (widget?.env == null || widget.env === "") {
const envNotSet = widget.env == null || widget.env === "";
const { data: containers, error: containersError } = useWidgetAPI(widget, envNotSet ? "" : "containers");
const { data: images, error: imagesError } = useWidgetAPI(widget, envNotSet ? "" : "images");
const { data: updates, error: updatesError } = useWidgetAPI(widget, envNotSet ? "" : "updates");
if (envNotSet) {
return <Container service={service} error={t("arcane.environment_required")} />;
}
const { data: containers, error: containersError } = useWidgetAPI(widget, "containers");
const { data: images, error: imagesError } = useWidgetAPI(widget, "images");
const { data: updates, error: updatesError } = useWidgetAPI(widget, "updates");
const error =
containersError ?? imagesError ?? updatesError ?? containers?.detail ?? images?.detail ?? updates?.detail;
if (error) {
+5 -1
View File
@@ -20,11 +20,15 @@ describe("widgets/arcane/component", () => {
});
it("shows an environment required error when env is missing", () => {
useWidgetAPI.mockImplementation(() => ({ data: undefined, error: undefined }));
renderWithProviders(<Component service={{ widget: { type: "arcane" } }} />, {
settings: { hideErrors: false },
});
expect(useWidgetAPI).not.toHaveBeenCalled();
// hooks always run; the empty endpoint is what skips the request
expect(useWidgetAPI).toHaveBeenCalledTimes(3);
useWidgetAPI.mock.calls.forEach((call) => expect(call[1]).toBe(""));
expect(screen.getByText("arcane.environment_required")).toBeInTheDocument();
});