Fix: re-enable global lint, fix un-caught warnings / errors (#6990)

src/components/errorboundry.jsx

@@ -15,7 +15,6 @@ export default class ErrorBoundary extends React.Component {
 
     // You can also log error messages to an error reporting service here
     if (error || errorInfo) {
-      // eslint-disable-next-line no-console
       console.error("component error: %s, info: %s", error, errorInfo);
     }
   }

src/components/quicklaunch.jsx

@@ -147,7 +147,7 @@ export default function QuickLaunch({ servicesAndBookmarks, searchString, setSea
         let descriptionMatch;
         if (searchDescriptions) {
           descriptionMatch = r.description?.toLowerCase().includes(searchString);
-          r.priority = nameMatch ? 2 * +nameMatch : +descriptionMatch; // eslint-disable-line no-param-reassign
+          r.priority = nameMatch ? 2 * +nameMatch : +descriptionMatch;
         }
         return nameMatch || descriptionMatch;
       });
@@ -244,7 +244,6 @@ export default function QuickLaunch({ servicesAndBookmarks, searchString, setSea
       <span>
         {parts.map((part, i) =>
           part.toLowerCase() === searchString.toLowerCase() ? (
-            // eslint-disable-next-line react/no-array-index-key
             <span key={`${searchString}_${i}`} className="bg-theme-300/10">
               {part}
             </span>

src/components/services/widget/error.jsx

@@ -13,13 +13,13 @@ export default function Error({ error }) {
   const { t } = useTranslation();
 
   if (typeof error === "string") {
-    error = { message: error }; // eslint-disable-line no-param-reassign
+    error = { message: error };
   } else if (typeof error === "number") {
-    error = { message: `Error ${error}` }; // eslint-disable-line no-param-reassign
+    error = { message: `Error ${error}` };
   }
 
   if (error?.data?.error) {
-    error = error.data.error; // eslint-disable-line no-param-reassign
+    error = error.data.error;
   }
 
   return (

src/components/widgets/resources/network.jsx

@@ -7,7 +7,6 @@ import Resource from "../widget/resource";
 
 export default function Network({ options, refresh = 1500 }) {
   const { t } = useTranslation();
-  // eslint-disable-next-line no-param-reassign
   if (options.network === true) options.network = "default";
 
   const { data, error } = useSWR(`/api/widgets/resources?type=network&interfaceName=${options.network}`, {

src/components/widgets/search/search.jsx

@@ -11,7 +11,7 @@ import {
 } from "@headlessui/react";
 import classNames from "classnames";
 import { useTranslation } from "next-i18next/pages";
-import { Fragment, useEffect, useState } from "react";
+import { Fragment, useEffect, useMemo, useState } from "react";
 import { BiLogoBing } from "react-icons/bi";
 import { FiSearch } from "react-icons/fi";
 import { SiBaidu, SiBrave, SiDuckduckgo, SiGoogle } from "react-icons/si";
@@ -57,12 +57,12 @@ export const searchProviders = {
   },
 };
 
-function getAvailableProviderIds(options) {
-  if (options.provider && Array.isArray(options.provider)) {
-    return options.provider.filter((value) => searchProviders.hasOwnProperty(value));
+function getAvailableProviderIds(provider) {
+  if (provider && Array.isArray(provider)) {
+    return provider.filter((value) => searchProviders.hasOwnProperty(value));
   }
-  if (options.provider && searchProviders[options.provider]) {
-    return [options.provider];
+  if (provider && searchProviders[provider]) {
+    return [provider];
   }
   return null;
 }
@@ -82,7 +82,8 @@ export function getStoredProvider() {
 export default function Search({ options }) {
   const { t } = useTranslation();
 
-  const availableProviderIds = getAvailableProviderIds(options) ?? [];
+  // options is a fresh object each render, so memo on provider itself
+  const availableProviderIds = useMemo(() => getAvailableProviderIds(options.provider) ?? [], [options.provider]);
 
   const [query, setQuery] = useState("");
   const [selectedProvider, setSelectedProvider] = useState(searchProviders[availableProviderIds[0] ?? "google"]);
@@ -184,7 +185,6 @@ export default function Search({ options }) {
               autoCapitalize="off"
               autoCorrect="off"
               autoComplete="off"
-              // eslint-disable-next-line jsx-a11y/no-autofocus
               autoFocus={options.focus}
               onBlur={(e) => e.preventDefault()}
               onKeyDown={handleSearchKeyDown}

src/components/widgets/unifi_console/unifi_console.jsx

@@ -14,7 +14,6 @@ import useWidgetAPI from "utils/proxy/use-widget-api";
 export default function Widget({ options }) {
   const { t } = useTranslation();
 
-  // eslint-disable-next-line no-param-reassign, no-multi-assign
   options.service_group = options.service_name = "unifi_console";
   const { data: statsData, error: statsError } = useWidgetAPI(options, "stat/sites", { index: options.index });
 
@@ -39,8 +38,8 @@ export default function Widget({ options }) {
   const lan = defaultSite.health.find((h) => h.subsystem === "lan");
   const wlan = defaultSite.health.find((h) => h.subsystem === "wlan");
   [wan, lan, wlan].forEach((s) => {
-    s.up = s.status === "ok"; // eslint-disable-line no-param-reassign
-    s.show = s.status !== "unknown"; // eslint-disable-line no-param-reassign
+    s.up = s.status === "ok";
+    s.show = s.status !== "unknown";
   });
   const name = wan.gw_name ?? defaultSite.desc;
   const uptime = wan["gw_system-stats"] ? wan["gw_system-stats"].uptime : null;

src/components/widgets/widget/container.jsx

@@ -10,7 +10,6 @@ import WidgetIcon from "./widget_icon";
 export function getAllClasses(options, additionalClassNames = "") {
   if (options?.style?.header === "boxedWidgets") {
     if (options?.style?.cardBlur !== undefined) {
-      // eslint-disable-next-line no-param-reassign
       additionalClassNames = [
         additionalClassNames,
         `backdrop-blur${options.style.cardBlur.length ? "-" : ""}${options.style.cardBlur}`,