vh/homepage
1
0
Fork 0
mirror of https://github.com/gethomepage/homepage.git synced 2026-09-12 07:05:56 -07:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

Tweak: improve nextauth error logging for easier debugging (#7070)
Docker CI / Docker Build & Push (push) Has been cancelled
Details
Lint / Linting Checks (push) Has been cancelled
Details
Release Drafter / Update Release Draft (push) Has been cancelled
Details
Release Drafter / Auto Label PR (push) Has been cancelled
Details
Tests / vitest (1) (push) Has been cancelled
Details
Tests / vitest (2) (push) Has been cancelled
Details
Tests / vitest (3) (push) Has been cancelled
Details
Tests / vitest (4) (push) Has been cancelled
Details

Browse Source
This commit is contained in:
shamoon
2026-08-28 12:23:55 -07:00
committed by GitHub
parent c46b3e6cff
commit e6ad43a76c
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/__tests__/pages/api/auth/[...nextauth].test.js
+2 -1
View File
@@ -73,6 +73,7 @@ describe("pages/api/auth/[...nextauth]", () => {
it("routes sanitized NextAuth logs through the Homepage logger", async () => { it("routes sanitized NextAuth logs through the Homepage logger", async () => {
const mod = await import("pages/api/auth/[...nextauth]"); const mod = await import("pages/api/auth/[...nextauth]");
const sensitiveMetadata = { const sensitiveMetadata = {
error: Object.assign(new Error("State cookie was missing."), { access_token: "sensitive-access-token" }),
clientSecret: "sensitive-client-secret", clientSecret: "sensitive-client-secret",
access_token: "sensitive-access-token", access_token: "sensitive-access-token",
id_token: "sensitive-id-token", id_token: "sensitive-id-token",
@@ -82,7 +83,7 @@ describe("pages/api/auth/[...nextauth]", () => {
mod.authOptions.logger.warn("NEXTAUTH_URL", sensitiveMetadata); mod.authOptions.logger.warn("NEXTAUTH_URL", sensitiveMetadata);
mod.authOptions.logger.debug("OAUTH_CALLBACK_RESPONSE", sensitiveMetadata); mod.authOptions.logger.debug("OAUTH_CALLBACK_RESPONSE", sensitiveMetadata);
expect(errorMock).toHaveBeenCalledWith("%s", "OAUTH_CALLBACK_ERROR"); expect(errorMock).toHaveBeenCalledWith("%s: %s", "OAUTH_CALLBACK_ERROR", "State cookie was missing.");
expect(warnMock).toHaveBeenCalledWith("%s", "NEXTAUTH_URL"); expect(warnMock).toHaveBeenCalledWith("%s", "NEXTAUTH_URL");
expect(debugMock).toHaveBeenCalledWith("%s", "OAUTH_CALLBACK_RESPONSE"); expect(debugMock).toHaveBeenCalledWith("%s", "OAUTH_CALLBACK_RESPONSE");
expect(JSON.stringify([...errorMock.mock.calls, ...warnMock.mock.calls, ...debugMock.mock.calls])).not.toContain( expect(JSON.stringify([...errorMock.mock.calls, ...warnMock.mock.calls, ...debugMock.mock.calls])).not.toContain(
src/pages/api/auth/[...nextauth].js
+11 -1
View File
@@ -71,6 +71,16 @@ function logFailedPasswordSignIn() {
createLogger("nextauth").warn("Failed password sign-in attempt"); createLogger("nextauth").warn("Failed password sign-in attempt");
} }
function logNextAuthError(code, metadata) {
const error = metadata instanceof Error ? metadata : metadata?.error;
if (error?.message) {
createLogger("nextauth").error("%s: %s", code, error.message);
} else {
createLogger("nextauth").error("%s", code);
}
}
let providers = []; let providers = [];
if (authEnabled) { if (authEnabled) {
if (hasOidcConfig) { if (hasOidcConfig) {
@@ -140,7 +150,7 @@ export const authOptions = {
signIn: "/auth/signin", signIn: "/auth/signin",
}, },
logger: { logger: {
error: (code) => createLogger("nextauth").error("%s", code), error: logNextAuthError,
warn: (code) => createLogger("nextauth").warn("%s", code), warn: (code) => createLogger("nextauth").warn("%s", code),
debug: (code) => createLogger("nextauth").debug("%s", code), debug: (code) => createLogger("nextauth").debug("%s", code),
}, },