diff --git a/src/components/widgets/stocks/stocks.jsx b/src/components/widgets/stocks/stocks.jsx index d82654d84..8c2c03fd0 100644 --- a/src/components/widgets/stocks/stocks.jsx +++ b/src/components/widgets/stocks/stocks.jsx @@ -44,41 +44,44 @@ export default function Widget({ options }) { >
- {data.stocks.map((stock) => ( -
- {stock.ticker} - {!viewingPercentChange ? ( - + stock && ( +
- {stock?.currentPrice !== "error" - ? t("common.number", { - value: stock.currentPrice, - style: "currency", - currency: "USD", - }) - : t("widget.api_error")} - - ) : ( - - {stock?.percentChange !== "error" ? `${stock.percentChange}%` : t("widget.api_error")} - - )} -
- ))} + {stock.ticker} + {!viewingPercentChange ? ( + + {stock.currentPrice !== null + ? t("common.number", { + value: stock.currentPrice, + style: "currency", + currency: "USD", + }) + : t("widget.api_error")} + + ) : ( + + {stock.percentChange !== null ? `${stock.percentChange}%` : t("widget.api_error")} + + )} +
+ ), + )}
diff --git a/src/pages/api/widgets/stocks.js b/src/pages/api/widgets/stocks.js index 48d5cdcff..12cfe2513 100644 --- a/src/pages/api/widgets/stocks.js +++ b/src/pages/api/widgets/stocks.js @@ -56,7 +56,7 @@ export default async function handler(req, res) { // API sometimes returns 200, but values returned are `null` if (c === null || dp === null) { - return { ticker: ticker || "error", currentPrice: "error", percentChange: "error" }; + return { ticker: ticker, currentPrice: null, percentChange: null }; } // Rounding percentage, but we want it back to a number for comparison diff --git a/src/widgets/stocks/component.jsx b/src/widgets/stocks/component.jsx index 2c901291c..5e73b0c25 100644 --- a/src/widgets/stocks/component.jsx +++ b/src/widgets/stocks/component.jsx @@ -64,8 +64,8 @@ function StockItem({ service, ticker }) {
{ticker}
- 0 ? "text-emerald-300" : "text-rose-300"}`}> - {data?.dp?.toFixed(2) ? `${data?.dp?.toFixed(2)}%` : t("widget.api_error")} + 0 ? "text-emerald-300" : "text-rose-300"}`}> + {data.dp?.toFixed(2) ? `${data.dp?.toFixed(2)}%` : t("widget.api_error")} {data.c