From 66a952b49b00bfd1854bdad769fee5fb225b53be Mon Sep 17 00:00:00 2001 From: Hamed Shams Date: Mon, 12 Oct 2026 15:23:19 +0300 Subject: [PATCH] fix: report a save or upload before re-ablating the model (#488) --- src/heretic/main.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/heretic/main.py b/src/heretic/main.py index f9c2823..dd5e521 100644 --- a/src/heretic/main.py +++ b/src/heretic/main.py @@ -946,6 +946,7 @@ def run(): save_directory, max_shard_size=settings.max_shard_size, ) + print(f"Model saved to [bold]{save_directory}[/].") else: print("Saving merged model...") merged_model = model.get_merged_model() @@ -958,10 +959,11 @@ def run(): model.tokenizer.save_pretrained(save_directory) if model.processor is not None: model.processor.save_pretrained(save_directory) + print(f"Model saved to [bold]{save_directory}[/].") + # Merging replaced the trial's adapter in place. + # Restore it only after the save has been reported. reset_trial_model() - print(f"Model saved to [bold]{save_directory}[/].") - if reproduction_mode: print("Verifying hashes of weight files...") @@ -1114,6 +1116,7 @@ def run(): max_shard_size=settings.max_shard_size, token=token, ) + print(f"Model uploaded to [bold]{repo_id}[/].") else: print("Uploading merged model...") merged_model = model.get_merged_model() @@ -1136,6 +1139,9 @@ def run(): private=private, token=token, ) + print(f"Model uploaded to [bold]{repo_id}[/].") + # Merging replaced the trial's adapter in place. + # Restore it only after the upload has been reported. reset_trial_model() if is_hf_path(settings.model): @@ -1200,8 +1206,6 @@ def run(): finally: settings.export_strategy = current_export_strategy - print(f"Model uploaded to [bold]{repo_id}[/].") - if reproduction_mode: print("Verifying hashes of weight files...")