mirror of
https://github.com/openglow-org/forgefirm.git
synced 2026-10-19 02:51:42 -07:00
ScottW514
36c1b75bb8
head_at_home placed the gantry stops at minus manual_home_x and manual_home_y as the settings read at the burn. A manual home reads them once: it declares the head at the stops at minus the offsets, and with an offset it moves the head to X0 Y0, that far in front of them. A write of the offsets after the home restarts no controller and keeps the X/Y reference. So a home made with 5 and 3, the offsets then cleared, had the head at X0 Y0 judged home 5 and 3 mm in front of the stops, and the burn started: the false PASS2172ae4set out to close. The other way round, offsets set after a home made with none failed a head that was at the stops. The home anchor holds the stops as the home declared them: /status reports the anchor's X and Y plus the step counters. head_at_home now takes the stops from the X and Y of the anchor (baseline.ANCHOR_PATH) when /status reports X and Y referenced by a manual home, and judges the head against them within HOME_TOL_MM. An anchor that is gone, or that is not a manual home of X and Y, fails the test before any start. The settings are read for the remedy alone. With an offset, the remedy names how the push ends: release the motors, push the head against the stops, and end the release with Energize motors ($ME), not with Set home here, which moves the head off the stops to X0 Y0 again. The remedy before said only to release the motors and push the head, and a release left standing makes the burn ask home-push, which the test does not answer. Without an offset it stays "home it there". The judge only refuses more: no energy or motion path changes. Proof: tests/test_setup_burns.py, the Unit tests step of forgetest-ci.yml (python -B -m unittest discover -s tests), 24 tests OK on Windows with python 3.14 and on Ubuntu 24.04 with python 3.12. BurnRunTests plants the anchor of a home with no offset beside the fake's /status, and test_a_manual_home_offset_puts_the_stops_off_x0_y0 plants the anchor of each home: a home made with 5 and 3 fails the head at X0 Y0 and passes it at X-5 Y-3; the offsets cleared after that home still fail the head at X0 Y0 before any start (no wizard start, no lever); the offsets set after a home made with none pass the head at X0 Y0; an anchor that is gone, or that reads as the startup's Z-only reference, fails before any start. That last pair replaces the leg where an offset that did not read as a number failed: the stops no longer come from the settings, and the rule that leg held (no stops placed, nothing starts) holds on the anchor. test_setup_dark.py (21) and test_manifest.py (39, with the guard on the suite's package imports, which setup_burns.py's import of baseline.py passes) pass. Negative controls on scratch copies: head_at_home as it was fails the case at the offsets cleared after the home (Failed not raised), and so do the stops read from the settings; an anchor that cannot be read taken as X0 Y0 fails it at the anchor that is gone; an anchor of any axes and any source fails it at the startup anchor. A probe of the failure text: with the offsets 5 and 3 it names Energize motors ($ME), not Set home here; with none it says "home it there". pyflakes reports no undefined name. Acceptance: setup.focus's fingerprint moves (setup_burns.py's shared text and the test's own description); the other 42 do not move (source_sha compared before and after). baseline.py is a shared judge already, in every hash. Against the campaign this series already needs, that adds no run:850498fmoved all 43 once.