mirror of
https://github.com/openglow-org/forgefirm.git
synced 2026-10-19 02:51:42 -07:00
forgetest: the shared judges' comments say why puls.py is one
The comment over SHARED_JUDGES in catalog.py said that every test runs through all four judges without importing them, puls.py among them, and the comment of test_a_shared_judge_edit_moves_every_test said the same. No test runs puls.py but the three that print the dark job (cloud.lid-interlock-abort, cloud.oversize-stream and exthost.armed-freeze, through offline_job), and suite/cloud.py imports it with `from .. import puls`: it is a judge because the sibling walk does not follow that import, as the Acceptance page of the site says. Both comments now say that every test runs through runner.py, hw.py and baseline.py with no import to follow, and that puls.py comes in by a package import the walk does not follow. Comments only: SHARED_JUDGES does not change. Proof: forgetest-ci "Unit tests" (`python -B -m unittest discover -s tests -v` in forgetest): test_manifest.py runs 39 tests, OK, on Windows with python 3.14 and on Ubuntu 24.04 with python 3.12. The only import of puls in the package is suite/cloud.py's (grep). pyflakes reports no undefined name. Acceptance: none. catalog.py is the registry and in no fingerprint, and tests/ are in none (source_sha of 43 of 43 unchanged).
This commit is contained in:
@@ -147,15 +147,17 @@ def source_file_sha(path):
|
|||||||
return hashlib.sha256(data).hexdigest()
|
return hashlib.sha256(data).hexdigest()
|
||||||
|
|
||||||
|
|
||||||
# The package modules every test runs through without importing them:
|
# The package modules that judge the machine. Every test runs through
|
||||||
# the Context a test is handed and the takeover (runner.py), the sysfs,
|
# the first three without importing them: the Context a test is handed
|
||||||
# LED, switch and HTTP readers behind it (hw.py), the fresh-boot idle
|
# and the takeover (runner.py), the sysfs, LED, switch and HTTP readers
|
||||||
# state judged around every run (baseline.py), and the dark job the
|
# behind it (hw.py), and the fresh-boot idle state judged around every
|
||||||
# cloud and extension tests print (puls.py). Their text is part of every
|
# run (baseline.py). puls.py is the dark job the cloud and extension
|
||||||
# judge, so it joins every implementation hash: a change to one of them
|
# tests print: suite/cloud.py imports it from the package (`from .. import
|
||||||
# moves every test. The rest of the package (the server, the page, the
|
# puls`), an import the sibling walk does not follow. Their text joins
|
||||||
# campaign rules, the artifact, the manifest, this registry, the bench
|
# every implementation hash: a change to one of them moves every test.
|
||||||
# actuator) judges nothing about the machine and stays out.
|
# The rest of the package (the server, the page, the campaign rules, the
|
||||||
|
# artifact, the manifest, this registry, the bench actuator) judges
|
||||||
|
# nothing about the machine and stays out.
|
||||||
SHARED_JUDGES = ("baseline.py", "hw.py", "puls.py", "runner.py")
|
SHARED_JUDGES = ("baseline.py", "hw.py", "puls.py", "runner.py")
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -611,9 +611,10 @@ def two(ctx):
|
|||||||
self.assertEqual((a2, b2), self.shas())
|
self.assertEqual((a2, b2), self.shas())
|
||||||
|
|
||||||
def test_a_shared_judge_edit_moves_every_test(self):
|
def test_a_shared_judge_edit_moves_every_test(self):
|
||||||
# runner.py, hw.py, baseline.py and puls.py are in every test's
|
# runner.py, hw.py and baseline.py are in every test's path with no
|
||||||
# path with no import to follow (the Context, the baseline around
|
# import to follow (the Context, the baseline around each run), and
|
||||||
# each run), so their text joins every implementation hash.
|
# puls.py comes in by a package import the walk does not follow, so
|
||||||
|
# their text joins every implementation hash.
|
||||||
judge = os.path.join(self.tmp, "hwlike.py")
|
judge = os.path.join(self.tmp, "hwlike.py")
|
||||||
|
|
||||||
def write_judge(text):
|
def write_judge(text):
|
||||||
|
|||||||
Reference in New Issue
Block a user