mirror of
https://github.com/openglow-org/forgefirm.git
synced 2026-09-27 16:51:12 -07:00
bench: every board-runnable tool ported to the bench page
The remaining bench diagnostics run from forgetest's #bench tab. The tools that also run from a LAN host share scripts/bench/gfbench.py: GF_HOST names a remote machine (host mode, sysfs through ssh, Grbl and forgectrl over the LAN); unset, the tool runs on the board itself (local mode, sysfs directly, everything on 127.0.0.1), which is how the page runs them - with GF_HOST=127.0.0.1, the panel token in GF_TOKEN and their data files under <data>/bench/ (FORGETEST_BENCH_DATA). The helper also reads a machine setting from forgectrl, or from the settings file on the board while forgectrl is stopped. Ported: pwm_sweep / pwm_hold (scope = a takeover; the latch relocked, the write refused if FIRE or LASER_ON reads active), pwm_stream_test (PASS/FAIL exit), flow_characterize, flow_recheck_char, flow_warm_validate and flow_matrix (takeovers: forgectrl owns the thermal hardware, so the page's takeover replaces the tools' own controller stop/restart, whose command line predated the supervisor; results and logs in the bench data directory), flow_sustained, fan_test, temp_calibrate (dry; watch bounded in seconds; the threshold and the coolant conversion from the shared code), flow_escalate_drill (cool_confirm_max_s shortened through forgectrl's settings for the drill and restored; the setting's minimum is the default budget), and live_fire_drills (<drill> [S] [F], all six drills, host from GF_HOST, token from the board). flow_matrix joins the registry. What stays unported cannot run against the machine at all: the two null-sink CI harnesses and the .puls decoder. Runner: a scope tool runs inside the takeover wrapper; the bench environment above is passed to every tool. Tests: test_bench_registry (registry <-> scripts/bench consistency, every ported tool builds its command line, every script compiles, gfbench host/local modes) and the server test (scope tool takeover, the environment reaching the tool). Local mode smoke-run on the bench (temp_calibrate watch, setting, token) from /tmp, removed after. No catalog consequence: bench tools are not image components (dev-only forgetest); the acceptance catalog is unchanged.
This commit is contained in:
+16
-4
@@ -203,10 +203,21 @@ change author's judgment (rule 1).
|
||||
|
||||
The same daemon serves `#bench`: the registry of the bench tools
|
||||
(`scripts/bench`, installed under `/usr/share/forgetest/bench/`), each with
|
||||
its safety class (`dry`, `takeover`, `live`, `scope`), argument form, and
|
||||
last run. A ported tool runs as a subprocess with the output on the page;
|
||||
unported tools are listed with Start disabled. Bench runs are recorded in
|
||||
`/data/forgetest/bench.jsonl` and never enter a campaign.
|
||||
its safety class, argument form, and last run. The classes: `dry` (reads
|
||||
or dry motion, forgectrl stays up), `takeover` (forgectrl and the
|
||||
controller stopped for the run, the pulse device free, the same wrapper
|
||||
the takeover tests use), `scope` (a takeover whose result only means
|
||||
something with the named instrument on the bench), `live` (emission
|
||||
possible; the operator acknowledgment and the physical arm press). A tool
|
||||
runs as a subprocess with the output on the page and, on the board, the
|
||||
machine as `GF_HOST=127.0.0.1`, the panel token in `GF_TOKEN`, and its data
|
||||
files under `/data/forgetest/bench/` (`FORGETEST_BENCH_DATA`); the same
|
||||
scripts run from a LAN host with `GF_HOST` set (`scripts/bench/gfbench.py`,
|
||||
`scripts/bench/README.md`). Every board-runnable tool is ported; the entries
|
||||
that stay unported are the CI harnesses of the null-sink controller and the
|
||||
factory `.puls` decoder, which do not run against the machine at all - they
|
||||
are listed so the catalog of what exists is complete. Bench runs are
|
||||
recorded in `/data/forgetest/bench.jsonl` and never enter a campaign.
|
||||
|
||||
## Layout
|
||||
|
||||
@@ -221,6 +232,7 @@ unported tools are listed with Start disabled. Bench runs are recorded in
|
||||
bench.py / coverage.py bench registry + subprocess runner; the lint
|
||||
suite/ the catalog, one module per subsystem
|
||||
forgetest/tests/ host unit tests (python3 -m unittest discover -s tests)
|
||||
scripts/bench/ the bench tools (+ gfbench.py, the board/host helper)
|
||||
scripts/acceptance-gate.py the gate
|
||||
scripts/manifest-from-tree.py manifest from the recipe pins (CI, workstation)
|
||||
releases/v<version>/ the committed artifacts
|
||||
|
||||
+33
-4
@@ -1630,6 +1630,33 @@ that image's campaign is a full one, unavoidably; from then on a
|
||||
component pin bump re-requires only the tests covering that component.
|
||||
Run the full campaign on the first pin-file image, not on `191951`.**
|
||||
|
||||
**2026-08-16, bench-tab ports complete (item 15b).** Every tool that can
|
||||
run against the machine is now runnable from the bench page: the scope
|
||||
tools (`pwm_sweep`, `pwm_hold` - now a takeover with a locked-state guard:
|
||||
the latch relocked, refused if FIRE or LASER_ON reads active;
|
||||
`pwm_stream_test` with a PASS/FAIL exit), the flow characterization
|
||||
family (`flow_characterize`, `flow_recheck_char`, `flow_warm_validate`,
|
||||
`flow_matrix` as takeovers - forgectrl owns the thermal hardware, so the
|
||||
page's takeover replaces the tools' own controller stop/restart, whose
|
||||
command line predated the supervisor; `flow_sustained`, `fan_test` and
|
||||
`temp_calibrate` stay dry), the escalation drill (`cool_confirm_max_s`
|
||||
shortened through forgectrl's settings and restored; the setting's
|
||||
minimum, 60 s, is the default budget) and the live drills (`<drill> [S]
|
||||
[F]`, all six, the token from the board). The host tools keep working
|
||||
from a workstation: `scripts/bench/gfbench.py` resolves `GF_HOST` (host
|
||||
mode, ssh) or the board itself (local mode; the page runs them that way
|
||||
with `GF_HOST=127.0.0.1`, `GF_TOKEN`, and their data files under
|
||||
`/data/forgetest/bench/`). Not ported, by nature: the two null-sink CI
|
||||
harnesses and the `.puls` decoder. Proof: `forgetest/tests/
|
||||
test_bench_registry.py` (registry <-> `scripts/bench` consistency, every
|
||||
ported tool builds its command line, every script compiles, gfbench host
|
||||
and local modes), the server test (a scope tool runs inside the takeover
|
||||
wrapper; the bench environment reaches the tool), and a local-mode smoke
|
||||
run on the bench (`temp_calibrate.py watch`, `gfbench.setting`, the
|
||||
token) staged in `/tmp` and removed. **The ported tools themselves have
|
||||
not been exercised from the page on the bench yet - that rides the next
|
||||
dev image (the confirmation campaign's image).**
|
||||
|
||||
## Hardware facts bank (measured)
|
||||
|
||||
- **DRV8825 stepper drivers wedge on 40 V rail glitches** (factory board;
|
||||
@@ -2966,9 +2993,11 @@ Run the full campaign on the first pin-file image, not on `191951`.**
|
||||
built with the pin files** (that build is a platform change against
|
||||
every result so far; after it, a component pin bump re-requires only
|
||||
the tests covering that component) - the tool on the bench is the
|
||||
tree, but a hot-patched image is not the image that ships; (b) the remaining
|
||||
bench-tab ports (scope tools, host-side flow characterization, the
|
||||
live drills - the catalog carries their acceptance forms); (c) the
|
||||
first release runs the full campaign and commits
|
||||
tree, but a hot-patched image is not the image that ships; (b) the
|
||||
bench-tab ports are **code-complete 2026-08-16** (every board-runnable
|
||||
tool is ported: the scope tools, the flow characterization family,
|
||||
the escalation drill, the live drills; record in "Release acceptance"
|
||||
above) - their bench validation rides the same next dev image; (c)
|
||||
the first release runs the full campaign and commits
|
||||
`releases/v<version>/acceptance.json` - **not yet: no release is
|
||||
cut.**
|
||||
|
||||
Reference in New Issue
Block a user