vh/forgefirm
1
0
Fork 0
mirror of https://github.com/openglow-org/forgefirm.git synced 2026-09-28 01:01:12 -07:00
Code Issues Packages Projects Releases Wiki Activity

forgetest: the stale boot reference judged at a held uptime, on both sides of the limit

Browse Source 
test_stale_preconfig_reference_is_retaken_on_a_fresh_boot read the host's
uptime after boot_reference() had read it to decide, and expected the
decision its own reading implied. On a CI runner the uptime crossed
BOOT_MAX_AGE_S (600 s) between the two readings: boot_reference retook
the reference and the test expected the stale one (forgetest-ci on
0eb0a16). The test now holds uptime_s() at 60 s under and over the limit
and judges both answers: retaken with the fresh sysfs under it, the stale
reference kept and marked over it.

Proof: test_baseline passes on Windows and on Linux; with
boot_reference() ignoring the uptime (a planted fault) the test fails in
all three classes that run it.
This commit is contained in:
ScottW514
2026-09-25 19:05:17 -04:00
parent 0eb0a16452
commit 8dc7c0bc56
1 changed files with 20 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
forgetest/tests/test_baseline.py
+20 -13
View File
@@ -434,22 +434,29 @@ class BaselineTests(unittest.TestCase):
"forgectrl": {"/settings": {"xy_microsteps": "16"}}})) "forgectrl": {"/settings": {"xy_microsteps": "16"}}}))
def test_stale_preconfig_reference_is_retaken_on_a_fresh_boot(self): def test_stale_preconfig_reference_is_retaken_on_a_fresh_boot(self):
# Both sides of BOOT_MAX_AGE_S, with the uptime held: read from the host, it can cross the limit
# between boot_reference()'s reading and the test's (it did, on a CI runner 600 s after its boot).
os.environ["FORGETEST_BOOT_ID"] = "test-boot-2" os.environ["FORGETEST_BOOT_ID"] = "test-boot-2"
real = baseline.uptime_s
try: try:
path = os.path.join(self.tmp, "boot-test-boot-2.json") for up, fresh in ((baseline.BOOT_MAX_AGE_S - 60, True), (baseline.BOOT_MAX_AGE_S + 60, False)):
with open(path, "w") as f: self.lines.clear()
json.dump({"ts": "old", "sysfs": {"cnc/motor_lock": "0", "cnc/step_freq": "10000", path = os.path.join(self.tmp, "boot-test-boot-2.json")
"cnc/y_mode": "1"}}, f) with open(path, "w") as f:
ref = baseline.boot_reference(self.lines.append, self.tmp) json.dump({"ts": "old", "sysfs": {"cnc/motor_lock": "0", "cnc/step_freq": "10000",
up = baseline.uptime_s() "cnc/y_mode": "1"}}, f)
if up is None or up > baseline.BOOT_MAX_AGE_S: baseline.uptime_s = lambda up=up: up
# too old to retake: the stale reference stands, marked ref = baseline.boot_reference(self.lines.append, self.tmp)
self.assertTrue(any("predates the controller's config" in l for l in self.lines)) if fresh:
self.assertEqual(ref["ts"], "old") self.assertTrue(any("retaking" in l for l in self.lines), self.lines)
else: self.assertNotEqual(ref["ts"], "old")
self.assertTrue(any("retaking" in l for l in self.lines)) self.assertEqual(ref["sysfs"]["cnc/motor_lock"], "0")
self.assertEqual(ref["sysfs"]["cnc/motor_lock"], "0") else:
# too old to retake: the stale reference stands, marked
self.assertTrue(any("predates the controller's config" in l for l in self.lines), self.lines)
self.assertEqual(ref["ts"], "old")
finally: finally:
baseline.uptime_s = real
os.environ.pop("FORGETEST_BOOT_ID", None) os.environ.pop("FORGETEST_BOOT_ID", None)