Judge a hand-back on what a run left, not on the machine still working

A leftover is dirt a run left behind. Four of the checks were reporting something else: the machine part-way through work of its own, which it finishes on its own a few seconds later. Each one failed a run that had done nothing wrong. laser.arm-wait-lid found it. The test passed every check it makes and failed on cool=smoke/armed=False/hold=False. The smoke clear is the engine's post-job work - run duty for smoke_s after an armed session, timed, ending by itself (cool.c, Cool_Smoke) - and the machine was idle fifteen seconds later without being asked. Armed and hold were both false: nothing had been left. The four, and what each was catching: cool a phase alone (the smoke clear, a cooldown). Armed or holding stays a leftover: the run left a job alive and the engine is keeping the fans up for it. controller the supervisor's own start. A takeover ends by starting forgectrl again, and the respawn runs the liveness probe and the lens reference before it reports running and verified. The run had put it back. state the ring draining to the end of a job. An underrun stays a leftover and is still acknowledged with cnc/stop: that one is the run's. leds read_led read brightness, write_led writes target, and the smooth trigger fades brightness toward target. An LED the machine had already released still read lit mid-fade, and the restore called itself done before the fade had moved. Judged on target now: a run that left the button lit left a target standing. The waiting, the restoring and the reporting of anything a run actually left are unchanged. What changed is which readings count as dirt. Host-proven: 87 baseline unit tests, two of them new - a fading button LED is not a leftover, a lit one is.
2026-09-27 16:51:12 -07:00 · 2026-09-10 12:51:05 -04:00
parent 4fbf14195b
commit 8d8ca2a8c6
2 changed files with 88 additions and 21 deletions
@@ -52,6 +52,13 @@ class BaselineTests(unittest.TestCase):
        # the class interface writes 'target'; the fake mirrors it into brightness
        # only when the test asks (see _sync_leds)

+    def _led2(self, name, target, brightness):
+        """Both attributes of one button LED: the trigger's commanded
+        level and the fade that follows it."""
+        for a, v in (("target", target), ("brightness", brightness)):
+            with open(self.leds + name + "/" + a, "w") as f:
+                f.write(v)
+
    def _sync_leds(self):
        for name in baseline.BUTTON_LEDS:
            p = self.leds + name + "/target"
@@ -370,6 +377,29 @@ if __name__ == "__main__":
    unittest.main()


+class TransientNotLeftoverTests(BaselineTests):
+    """A leftover is what a run left behind, not the machine part-way
+    through its own work. Found on the bench reference, where
+    laser.arm-wait-lid passed every check it makes and failed its
+    hand-back on the post-job smoke clear."""
+
+    def test_a_fading_button_led_is_not_a_leftover(self):
+        # the trigger fades brightness toward target: target 0 with
+        # brightness still high is the fade from a level the machine ended
+        for name in baseline.BUTTON_LEDS:
+            self._led2(name, target="0", brightness="900")
+        left = self.bl().enforce("post", captured=None)
+        self.assertEqual([x for x in left if x.item.startswith("leds/")], [])
+
+    def test_a_lit_button_led_is_a_leftover(self):
+        # a target the run left standing is dirt, whatever the fade reads
+        self._led2(baseline.BUTTON_LEDS[0], target="1014", brightness="0")
+        left = self.bl().enforce("post", captured=None)
+        items = [x for x in left if x.item.startswith("leds/")]
+        self.assertEqual(len(items), 1)
+        self.assertEqual(items[0].found, "1014")
+
+
 class PositionDeadbandTests(unittest.TestCase):
    """The counters count steps and a controller's own return lands within
    a few hundredths of a millimeter, not on the step: a difference that