Catalog: the report channel, the event stream and what-changed leave

Three catalog tests leave for the host proofs that now carry them; the
catalog goes from 106 to 103.

- cooling.report-channel. forgectrl's tests/host_routes.sh (e69d967)
  runs the channel against a live daemon: a run report with the
  controller's secret writes exhaust 65535; no secret, a wrong secret
  and a short secret are 403 and the duty file is unchanged; an accepted
  idle while the ring still reads running writes 32768; the secret dies
  with the controller. cool_report_test.py and super_test case L own the
  secret, and cooling.fans-quiet-after-motion owns the live M8/M9 return
  to the idle duty. The forged Host: localhost was the same secret
  refusal.
- events.stream. events_test.c owns the hello, the replacement, and
  motors.released; host_routes.sh owns the live cap (three peers held,
  a fourth 503, GET /settings 200 beside them, closing one admitting the
  next). forgectrl.lease and exthost.events still cover src/events.*,
  and _EventStream stays for forgectrl.lease.
- setup.what-changed. setup_test holds tray -> laser.focus and fan ->
  airflow under the image's table beside tube -> laser.floor;
  host_routes.sh holds /wiz/changed (403, 400) and that every step the
  menu names is one GET /wiz lists. src/setup.* and src/wiz.* stay
  covered by the other setup tests, and help.js, panel.js and index.html
  by camera.key-read. preserved() and flag_of() go with it; recommended()
  stays.

tests/test_setup_suite.py drops setup.what-changed from the id list, the
takeover list and the covers lookup, and its flag_of case keeps only
the recommended() assertion.

test_setup_suite.py passes (36 tests). The coverage lint on the tree
manifest finds no uncovered path across the 103 tests; its one finding
is setup.check-lens's empty src/lensfind.* entry, which the forgectrl
pin bump clears. pyflakes on the four files reports only the unused t0
in cooling.py that HEAD already has. The full forgetest suite was not
run.

Fingerprints: the cuts change the shared text of suite/cooling.py,
suite/forgectrl.py and suite/setup.py, so 56 of the 103 tests'
implementation hashes move (cooling 12, setup 26, forgectrl 5, and
exthost 13 through its import of suite/forgectrl.py). The next forgectrl
pin bump already owes 54 of them; exthost.platform and
setup.machine-name are the two it adds. releases/ is unchanged.

forgetest/tests/test_setup_suite.py

@@ -23,7 +23,7 @@ IDS = ("setup.gate-blocks-controllers",
        "setup.advisories-rehash", "setup.account-login", "setup.https-only-writes",
        "setup.ssh-until-reboot", "setup.cloud-disabled-surface",
        "setup.factory-return", "setup.machine-name", "setup.first-run-flow",
-       "setup.first-run-page", "setup.what-changed", "setup.record-export",
+       "setup.first-run-page", "setup.record-export",
        "setup.mirror")
 OPERATOR = ("setup.first-run-flow", "setup.first-run-page")
 
@@ -48,30 +48,22 @@ class RegistrationTests(unittest.TestCase):
     def test_the_record_swapping_tests_are_takeovers(self):
         for tid in ("setup.gate-blocks-controllers", "setup.advisories-rehash",
                     "setup.first-run-flow", "setup.first-run-page",
-                    "setup.what-changed", "setup.mirror"):
+                    "setup.mirror"):
             self.assertEqual(self.reg[tid].hardware, "takeover", tid)
         self.assertEqual(self.reg["setup.record-export"].hardware, "api")
 
     def test_the_lifecycle_tests_cover_their_files(self):
-        changed = set(self.reg["setup.what-changed"].covers)
         export = set(self.reg["setup.record-export"].covers)
         mirror = set(self.reg["setup.mirror"].covers)
-        self.assertIn(("forgectrl", "src/ui/panel.js"), changed)
         self.assertIn(("forgectrl", "src/recordhtml.*"), export)
         self.assertIn(("forgectrl", "src/logs.*"), export)
         self.assertIn(("forgectrl", "src/wizdark.*"), mirror)
         self.assertIn("setup.check-sensors", self.reg["setup.mirror"].requires)
 
-    def test_flag_of_reads_the_status_document(self):
+    def test_recommended_reads_the_status_document(self):
         w = {"recommended": [{"id": "laser.floor", "reason": "the tube was replaced"},
                              {"id": "laser.focus", "reason": "the tray was replaced"},
                              {"id": "airflow", "reason": "not run yet"}, "stray"]}
-        self.assertEqual(setup.flag_of(w, "laser.floor"), "the tube was replaced")
-        self.assertEqual(setup.flag_of(w, "laser.focus"), "the tray was replaced")
-        self.assertEqual(setup.flag_of(w, "airflow"), "not run yet")
-        self.assertIsNone(setup.flag_of(w, "stray"))                     # only an entry with an id counts
-        self.assertIsNone(setup.flag_of(w, "cameras"))
-        self.assertIsNone(setup.flag_of({}, "x"))
         self.assertEqual(setup.recommended(w), {"laser.floor": "the tube was replaced",
                                                 "laser.focus": "the tray was replaced",
                                                 "airflow": "not run yet"})