fix(lora-worker): default network_alpha to dim/2 to match proven Sindra runs
comfy-dev cross-check: Sindra v1/v2 used alpha=dim/2 (0.5 LoRA scaling), which produced the validated likeness; the initial alpha=dim (1.0) was a stronger, unvalidated default. Align the default to the proven value (operator/per-request can still override). Tests updated (14 green).
This commit is contained in:
@@ -124,8 +124,8 @@ def test_relative_dataset_dir_rejected():
|
||||
|
||||
def test_alpha_scales_with_dim():
|
||||
_, _, params = build_command(_req(tier="fast"))
|
||||
# fast -> dim 16; alpha = dim * ratio (default 1.0) = 16
|
||||
# fast -> dim 16; alpha = dim * ratio (0.5, matching Sindra) = 8
|
||||
argv, _, _ = build_command(_req(tier="fast"))
|
||||
assert _flag_value(argv, "--network_dim") == "16"
|
||||
assert _flag_value(argv, "--network_alpha") == "16"
|
||||
assert _flag_value(argv, "--network_alpha") == "8"
|
||||
assert params["dim"] == 16
|
||||
|
||||
Reference in New Issue
Block a user