vh
0233ca64fb
The in-place client half of the anti-slop interaction work (guidelines G1, G2, G4, G13). It still never re-POSTs, still serializes saves, and a batch still never reloads. - Focus: the focused element is recorded by identity (its region, its key, which same-key element it was) and the fresh one is focused without scrolling. If an answered pick's form folds into a closed <details>, focus goes to its summary; if nothing is left, to the region (tabindex=-1, set by the script). Focus outside the swapped regions is not touched. - One status line per page (_status.html). It floats at the bottom centre, above the fixed review stage, so it moves nothing and is in view wherever the reader is. Wider than 900px, the letterhead and footer the review covers leave the Tab order (visibility:hidden, CSS only). - The line is never hidden: empty, it takes no space and stays displayed. "Saving…" at the press, "Still saving…" on a repeat press, "Saved." when the swap lands (cleared after 2s if still the same write), and warnings with data-tone="warn". Every write sets or clears the tone. The form in flight carries aria-busy until its save settles. - The client never reloads over a draft: both of its reloads run only when every in-place form is clean except the one just sent, unchanged since its press, asked again at the reload beat; otherwise it says so and stays. A beforeunload guard asks when an in-place form is dirty (its own reload does not ask). The embed asks when one of our answers is unsent, and skips the pressed form on its own one-form submit. - Six booth-dev browser tests read the line's hidden state; they read its words and tone instead. Two r2_submit_all.toml rows are re-anchored to the same failure in the moved code. Folded from the heid bug-hunt (panel 4/4, thread 01M3MRTNTWEPJHTN4APRR81KH4): - aria-busy mirrors which forms are in flight on the LIVE page. It is set at the press and re-synced whenever a save settles, so it ends on every path (a stale tile the swap never replaced included), and a queued form replaced by an earlier swap is marked busy again. - A press inside the reload beat cancels the reload. - A failure that stayed is said again after an unrelated save, rather than buried under "Saved.". - A 204 followed by a failed page GET is "Saved.", never "could not save". - An edit made while its save flew is said to be unsaved. - A focused <summary> has a key. - The queue settles on rejection. - The embed's skip covers the one navigation its submit starts; a cancelled submit, or one that leaves the page in place, is guarded again. - Pinned: no in-place form holds a control dirty() cannot read, and no region nests in another. Folded from this slice's gate: the status line floats (fixed, bottom centre, above the review stage) instead of sitting at the top of <main> or under the viewer's bar. In the flow, every save's "Saving…" moved the page; booth-dev's test_a_flag_lands_in_place_and_every_region_catches_up caught a 50px jump. The viewers' grids are back as they were. Contract: as_antislop S5b (heid contract review and bug-hunt folded). Falsifiers: antislop.toml S5b sections.
111 lines
4.7 KiB
TOML
111 lines
4.7 KiB
TOML
# R2 C3 step 3a, 2026-09-27: one submit saves every changed pick on a Booth
|
|
# page (the marks page, the lightbox's verdict aside, the review rail). The
|
|
# Booth-page half of the operator's report; the verbatim half is
|
|
# u3_submit_all.toml. Contract: docs/contracts/r2_flow.contract.md, C3 step 3a.
|
|
# The flight-window and refusal rows came from the heid bug-hunt panel on the
|
|
# first cut.
|
|
|
|
unit = "r2 submit all"
|
|
|
|
[[mutation]]
|
|
label = "the other pick forms are ignored (one form, one save, as before)"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_one_submit_on_the_marks_page_saves_every_changed_pick"
|
|
old = '''
|
|
var batch = pickBatch(form);'''
|
|
new = '''
|
|
var batch = null;'''
|
|
|
|
[[mutation]]
|
|
label = "the pressed pick is sent even when blank (its 400 reloads the rest away)"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_pressing_a_blank_picks_submit_saves_the_others_and_skips_it"
|
|
old = '''
|
|
return others ? picks.filter(function (f) { return dirty(f) && !pending[flightKey(f)]; }) : null;'''
|
|
new = '''
|
|
return others ? picks.filter(function (f) { return (f === form || dirty(f)) && !pending[flightKey(f)]; }) : null;'''
|
|
|
|
[[mutation]]
|
|
label = "a refusal stops the picks after it"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_a_refused_pick_in_a_batch_costs_only_itself_and_clears_nothing"
|
|
old = '''
|
|
return post(f, datas[i]).then(function () {'''
|
|
new = '''
|
|
if (refused.length) return;
|
|
return post(f, datas[i]).then(function () {'''
|
|
|
|
[[mutation]]
|
|
label = "a refused batch reloads (the refused pick and every draft are lost)"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_a_refused_pick_in_a_batch_costs_only_itself_and_clears_nothing"
|
|
old = '''
|
|
var shown = saved.length ? refresh(saved, true) : Promise.resolve(true);'''
|
|
new = '''
|
|
if (refused.length) { fail(); return; }
|
|
var shown = saved.length ? refresh(saved, true) : Promise.resolve(true);'''
|
|
|
|
[[mutation]]
|
|
label = "a refused pick counts as sent, so its input comes back as the server has it"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_a_refused_pick_in_a_batch_costs_only_itself_and_clears_nothing"
|
|
old = '''
|
|
}, function (e) { refused.push(askOf(f) + ' (' + e.message + ')'); });'''
|
|
new = '''
|
|
}, function (e) { saved.push({key: flightKey(f), snap: snaps[i]}); refused.push(askOf(f) + ' (' + e.message + ')'); });'''
|
|
|
|
[[mutation]]
|
|
label = "a form in flight stops counting as another dirty form (a clean press 400s mid-save)"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_pressing_a_clean_pick_during_a_batch_sends_nothing"
|
|
old = '''
|
|
return f.getAttribute('action') === action && isPick(f);'''
|
|
new = '''
|
|
return f.getAttribute('action') === action && isPick(f) && !pending[flightKey(f)];'''
|
|
|
|
[[mutation]]
|
|
label = "in flight is marked on the node, so a swap's fresh copy can be sent twice"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_a_pick_in_flight_stays_in_flight_across_another_saves_swap"
|
|
old = '''
|
|
function flightKey(f) { return formKey(f); }'''
|
|
new = '''
|
|
var nth = 0;
|
|
function flightKey(f) { return f.__fk || (f.__fk = 'n' + (++nth)); }'''
|
|
|
|
[[mutation]]
|
|
label = "a new save does not clear the last one's words"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_a_later_save_clears_a_stale_not_saved_line"
|
|
old = '''
|
|
st.textContent = text;'''
|
|
new = '''
|
|
if (!st.textContent) st.textContent = text;'''
|
|
|
|
[[mutation]]
|
|
label = "a batch whose refresh fails reloads (every unsent draft with it)"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_a_batch_whose_refresh_fails_keeps_the_page"
|
|
old = '''
|
|
var shown = saved.length ? refresh(saved, true) : Promise.resolve(true);'''
|
|
new = '''
|
|
var shown = saved.length ? refresh(saved, true).catch(function (e) { reload(); throw e; }) : Promise.resolve(true);'''
|
|
|
|
[[mutation]]
|
|
label = "a sent form counts as sent even when it changed after the press"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_a_change_to_a_sent_pick_during_the_flight_is_kept"
|
|
old = '''
|
|
if (recs[i].key === k && recs[i].snap === serial(f)) return true;'''
|
|
new = '''
|
|
if (recs[i].key === k) return true;'''
|
|
|
|
[[mutation]]
|
|
label = "no form counts as sent (a saved note's text carries back as a draft)"
|
|
file = "booth/templates/base.html"
|
|
test = "tests/test_flow_browser.py::test_a_saved_notes_box_comes_back_empty"
|
|
old = '''
|
|
if (recs[i].key === k && recs[i].snap === serial(f)) return true;'''
|
|
new = '''
|
|
if (false) return true;'''
|