{{ b.count }} item{{ '' if b.count == 1 else 's' }}
{% if b.flags %} ·
{{ b.flags }} flagged{% endif %}
· {{ lifetime(b.kept, b.hold, b.expires_in) }}
+ {%- if b.kept %}
+
+ {%- else %}
+
+ {%- endif %}
·
⬇ zip
+ {%- if b.kept %}
+ ·
+ {%- else %}
+ ·
+ {%- endif %}
{% if b.marks_open %}
? {{ b.marks_open }} open
{% elif b.hold == "unreadable" %}
marks unreadable
{% elif section == 'new' %}
new{% endif %}
{% if b.uploaded %}
⬆ pickup{% endif %}
-
- {# Keep / release and the ×. The confirmation text is DATA-DRIVEN: the
- booth name travels as a data attribute and never reaches a JS string
- (see the script below). Release is reversible, so it has no prompt of
- its own beyond the wording. #}
- {% if b.kept %}
-
-
- {% else %}
-
-
- {% endif %}
-
'''
+new = '''
+ {% if true %}
+
'''
+
+[[mutation]]
+label = "the stacked Desk column is a bare 1fr (content sets its minimum)"
+file = "booth/templates/base.html"
+test = "tests/test_flow_browser.py::test_the_desk_never_scrolls_sideways_on_a_phone"
+old = '''
+ @media (max-width:1000px){.desk{grid-template-columns:minmax(0,1fr)}}'''
+new = '''
+ @media (max-width:1000px){.desk{grid-template-columns:1fr}}'''
diff --git a/tests/test_flow_browser.py b/tests/test_flow_browser.py
index 78daedd..62d7bf1 100644
--- a/tests/test_flow_browser.py
+++ b/tests/test_flow_browser.py
@@ -374,3 +374,61 @@ def test_the_next_arrow_clears_the_rail_only_beside_it(browser, live):
"getComputedStyle(document.querySelector('.vnav.vnext')).right")
page.close()
assert rights == {1400: "360px", 390: "0px"}
+
+
+def test_a_rows_keep_release_and_wipe_take_no_room_of_their_own(browser, live):
+ """Operator, on the live Desk: 'release and x take up space whether or not
+ they're visible.' They were `opacity:0` in their own side column, which
+ hides a control and still reserves its box. Each now sits on the facts
+ line beside the state it changes, visible without hover (a touch screen
+ never had hover), so a row with no badge has no side column at all."""
+ import os
+ base, root = live
+ past = time.time() - 10_000
+ for name, kept in (("kept1", True), ("loose", False)):
+ d = root / name
+ d.mkdir()
+ (d / "a.png").write_bytes(PNG)
+ os.utime(d / "a.png", (past, past))
+ (d / ".viewed").write_bytes(b"") # looked at since: no 'new' badge
+ if kept:
+ (d / ".forever").write_bytes(b"")
+ page = browser.new_page(viewport={"width": 1400, "height": 900})
+ page.goto(f"{base}/", wait_until="networkidle")
+ page.mouse.move(0, 0) # nothing hovered
+ out = {}
+ for name, form in (("kept1", "form.release"), ("kept1", "form.wipe-kept"),
+ ("loose", "form.keepit"), ("loose", "form.wipe")):
+ btn = page.locator(f'.desk-row[data-booth="{name}"] {form} button')
+ out[(name, form)] = btn.is_visible() and btn.evaluate(
+ "b => { for (let e = b; e; e = e.parentElement)"
+ " if (getComputedStyle(e).opacity === '0') return false;"
+ " return true; }")
+ gaps = page.evaluate("""() => [...document.querySelectorAll('.desk-row')].map(r => {
+ const row = r.getBoundingClientRect(), main = r.querySelector('.desk-main').getBoundingClientRect();
+ return Math.round(row.right - main.right); })""")
+ page.close()
+ assert all(out.values()), out
+ # row padding (12) + border (1) + nothing else: no side column is reserved
+ assert gaps and max(gaps) <= 14, gaps
+
+
+def test_the_desk_never_scrolls_sideways_on_a_phone(browser, live):
+ """The row-controls change made a Desk row a flex container, and a long
+ provenance line (nowrap, ellipsised) then set the Desk column's MINIMUM
+ width: at 390px the page scrolled sideways to 1029px. The column is capped
+ at the space it has; the ellipsis does the rest."""
+ from booth.manifest import write_manifest
+ base, root = live
+ d = root / "longwhy"
+ d.mkdir()
+ (d / "a.png").write_bytes(PNG)
+ write_manifest(d, "design-dev", title="A set with a long reason",
+ why="a reason long enough to overflow any phone " * 6)
+ widths = {}
+ for w in (390, 1400):
+ page = browser.new_page(viewport={"width": w, "height": 844})
+ page.goto(f"{base}/", wait_until="networkidle")
+ widths[w] = page.evaluate("document.documentElement.scrollWidth")
+ page.close()
+ assert widths == {390: 390, 1400: 1400}, widths