vh/booth
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(embed,mutation): SPYRJA fold — report input on every path; an instrument that cannot certify what it did not run

Browse Source 
The heid bug-hunt (hulda, with heid's second voice) on 377e652 found eight
issues. Every fixed one has a red-first test.

embed.js:
- H1: the report-input guard covered only the batch path. A lone changed
  answer went out as a native POST, whose 303 navigation took the report's
  typed text with it. Unsaved report input now routes even a lone answer
  in place. With nothing of ours to send, the submit block says so.
- H7 / V1: a bare <select>, and a range or color input with no value
  attribute, read as typed-into by their default attributes, so every clean
  batch refused its reload with a false message. Report controls are now
  measured against how they stood when the Booth mounted. A control added
  later falls back to its defaults, counting a select's first option as its
  default.
- H2 / V2: a contenteditable region counts as report input.

scripts/mutation_check.py:
- H5: any non-zero exit counted as proof, including a collection error
  where the test never ran. Only pytest's "tests failed" (1) proves now.
- H6: the test run has a timeout (300 s). A hang reports "timed out" and
  the source is still restored.
- H3: source is read and restored as bytes, so a CRLF file comes back
  byte-exact.
- H4: one run per tree, enforced by a lock. The in-flight marker lives with
  the tree it guards.
- H8: anchors are counted with overlaps. The check is `matches()`, not
  str.count.

Tool controls +5 (tests/test_mutation_check.py). u3_submit_all +3 rows.
This commit is contained in:
vh
2026-09-28 17:49:13 -07:00
parent 377e652670
commit 213071b6ce
6 changed files with 295 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_embed_browser.py
+73
View File
@@ -1058,3 +1058,76 @@ def test_a_clean_batch_does_not_reload_over_text_typed_into_the_report(browser,
assert same and kept == "my own working", (same, kept)
assert "reload" in said.lower(), said
assert {k: v["choice"] for k, v in _answers(b).items()} == {"a1": "yes", "a2": "no"}
def test_a_single_answer_does_not_navigate_over_text_typed_into_the_report(browser, live):
"""SPYRJA H1 (hulda): the report-input guard covered only the batch path.
One changed ask went to the browser's own POST and its 303 — a navigation
that took the report's typed text with it. Unsaved report input now sends
even a lone answer the in-place way."""
base, data = live
b = _asks(data / "b", ("a1", "a2"))
html = ("<!doctype html><title>r</title><body>"
'<textarea id="scratch"></textarea>'
f"{SEAM}</body>")
page = _open(browser, base, "b", html, b)
page.wait_for_selector("#bk-ask-a2-submit")
page.evaluate("window.__same = 1")
posts = _watch_posts(page)
page.fill("#scratch", "my own working")
_choice(page, "a1", "yes")
_press(page, "a1")
page.wait_for_selector("#bk-ask-a1-submit .bk-ask-status:not([hidden])", timeout=10000)
same = page.evaluate("window.__same === 1")
kept = page.input_value("#scratch")
page.close()
assert posts == [("fetch", "a1")], posts
assert same and kept == "my own working", (same, kept)
assert _answers(b)["a1"]["choice"] == "yes"
def test_untouched_report_controls_do_not_hold_the_reload(browser, live):
"""SPYRJA H7 / heid V1: a bare <select> shows its first option selected
while no option is defaultSelected, and a range or color input has a value
and no value attribute — so they read as typed-into before anyone touched
them, and every clean batch refused to reload with a false message. The
report's controls are measured against how they stood when the Booth
mounted."""
base, data = live
b = _asks(data / "b", ("a1", "a2"))
html = ("<!doctype html><title>r</title><body>"
"<select id=s><option>a</option><option>b</option></select>"
'<input type="range" id="r"><input type="color" id="c">'
f"{SEAM}</body>")
page = _open(browser, base, "b", html, b)
page.wait_for_selector("#bk-ask-a2-submit")
_choice(page, "a1", "yes")
_choice(page, "a2", "no")
with page.expect_navigation(timeout=10000):
_press(page, "a1")
page.close()
assert {k: v["choice"] for k, v in _answers(b).items()} == {"a1": "yes", "a2": "no"}
def test_a_clean_batch_does_not_reload_over_an_edited_contenteditable(browser, live):
"""SPYRJA H2 / heid V2: text typed into a report's contenteditable region
is input too, and the reload took it."""
base, data = live
b = _asks(data / "b", ("a1", "a2"))
html = ("<!doctype html><title>r</title><body>"
'<div id="ed" contenteditable="true">first</div>'
f"{SEAM}</body>")
page = _open(browser, base, "b", html, b)
page.wait_for_selector("#bk-ask-a2-submit")
page.evaluate("window.__same = 1")
page.click("#ed")
page.keyboard.press("End")
page.keyboard.type(" and more")
_choice(page, "a1", "yes")
_choice(page, "a2", "no")
_press(page, "a1")
page.wait_for_selector("#bk-ask-a1-submit .bk-ask-status:not([hidden])", timeout=10000)
same = page.evaluate("window.__same === 1")
text = page.inner_text("#ed")
page.close()
assert same and text == "first and more", (same, text)