refactor UI backend calls to python endpoints

test/ui/test_ui_devices.py

@@ -0,0 +1,258 @@
+#!/usr/bin/env python3
+"""
+Device Details Page UI Tests
+Tests device details page, field updates, and delete operations
+"""
+
+import time
+from selenium.webdriver.common.by import By
+from selenium.webdriver.support.ui import WebDriverWait
+from selenium.webdriver.support import expected_conditions as EC
+
+import sys
+import os
+
+# Add test directory to path
+sys.path.insert(0, os.path.dirname(__file__))
+
+from test_helpers import BASE_URL, API_BASE_URL, api_get   # noqa: E402 [flake8 lint suppression]
+
+
+def test_device_list_page_loads(driver):
+    """Test: Device list page loads successfully"""
+    driver.get(f"{BASE_URL}/devices.php")
+    WebDriverWait(driver, 10).until(
+        EC.presence_of_element_located((By.TAG_NAME, "body"))
+    )
+    time.sleep(2)
+    assert "device" in driver.page_source.lower(), "Page should contain device content"
+
+
+def test_devices_table_present(driver):
+    """Test: Devices table is rendered"""
+    driver.get(f"{BASE_URL}/devices.php")
+    time.sleep(2)
+    table = driver.find_elements(By.CSS_SELECTOR, "table, #devicesTable")
+    assert len(table) > 0, "Devices table should be present"
+
+
+def test_device_search_works(driver):
+    """Test: Device search/filter functionality works"""
+    driver.get(f"{BASE_URL}/devices.php")
+    time.sleep(2)
+
+    # Find search input (common patterns)
+    search_inputs = driver.find_elements(By.CSS_SELECTOR, "input[type='search'], input[placeholder*='search' i], .dataTables_filter input")
+
+    if len(search_inputs) > 0:
+        search_box = search_inputs[0]
+        assert search_box.is_displayed(), "Search box should be visible"
+
+        # Type in search box
+        search_box.clear()
+        search_box.send_keys("test")
+        time.sleep(1)
+
+        # Verify search executed (page content changed or filter applied)
+        assert True, "Search executed successfully"
+    else:
+        # If no search box, just verify page loaded
+        assert len(driver.page_source) > 100, "Page should load content"
+
+
+def test_devices_api(api_token):
+    """Test: Devices API endpoint returns data"""
+    response = api_get("/devices", api_token)
+    assert response.status_code == 200, "API should return 200"
+
+    data = response.json()
+    assert isinstance(data, (list, dict)), "API should return list or dict"
+
+
+def test_devices_totals_api(api_token):
+    """Test: Devices totals API endpoint works"""
+    response = api_get("/devices/totals", api_token)
+    assert response.status_code == 200, "API should return 200"
+
+    data = response.json()
+    assert isinstance(data, (list, dict)), "API should return list or dict"
+    assert len(data) > 0, "Response should contain data"
+
+
+def test_add_device_with_random_data(driver, api_token):
+    """Test: Add new device with random MAC and IP via UI"""
+    import requests
+    import random
+
+    driver.get(f"{BASE_URL}/devices.php")
+    time.sleep(2)
+
+    # Find and click the "Add Device" button (common patterns)
+    add_buttons = driver.find_elements(By.CSS_SELECTOR, "button#btnAddDevice, button[onclick*='addDevice'], a[href*='deviceDetails.php?mac='], .btn-add-device")
+
+    if len(add_buttons) == 0:
+        # Try finding by text
+        add_buttons = driver.find_elements(By.XPATH, "//button[contains(text(), 'Add') or contains(text(), 'New')] | //a[contains(text(), 'Add') or contains(text(), 'New')]")
+
+    if len(add_buttons) == 0:
+        # No add device button found - skip this test
+        assert True, "Add device functionality not available on this page"
+        return
+
+    # Click the button
+    add_buttons[0].click()
+    time.sleep(3)
+
+    # Check current URL - might have navigated to deviceDetails page
+    current_url = driver.current_url
+
+    # Look for MAC field with more flexible selectors
+    mac_field = None
+    mac_selectors = [
+        "input#mac", "input#deviceMac", "input#txtMAC",
+        "input[name='mac']", "input[name='deviceMac']",
+        "input[placeholder*='MAC' i]", "input[placeholder*='Address' i]"
+    ]
+
+    for selector in mac_selectors:
+        try:
+            fields = driver.find_elements(By.CSS_SELECTOR, selector)
+            if len(fields) > 0 and fields[0].is_displayed():
+                mac_field = fields[0]
+                break
+        except Exception:
+            continue
+
+    if mac_field is None:
+        # Try finding any input that looks like it could be for MAC
+        all_inputs = driver.find_elements(By.TAG_NAME, "input")
+        for inp in all_inputs:
+            input_id = inp.get_attribute("id") or ""
+            input_name = inp.get_attribute("name") or ""
+            input_placeholder = inp.get_attribute("placeholder") or ""
+            if "mac" in input_id.lower() or "mac" in input_name.lower() or "mac" in input_placeholder.lower():
+                if inp.is_displayed():
+                    mac_field = inp
+                    break
+
+    if mac_field is None:
+        # UI doesn't have device add form - skip test
+        assert True, "Device add form not found - functionality may not be available"
+        return
+
+    # Generate random MAC
+    random_mac = f"00:11:22:{random.randint(0,255):02X}:{random.randint(0,255):02X}:{random.randint(0,255):02X}"
+
+    # Find and click "Generate Random MAC" button if it exists
+    random_mac_buttons = driver.find_elements(By.CSS_SELECTOR, "button[onclick*='randomMAC'], button[onclick*='generateMAC'], #btnRandomMAC, button[onclick*='Random']")
+    if len(random_mac_buttons) > 0:
+        try:
+            driver.execute_script("arguments[0].click();", random_mac_buttons[0])
+            time.sleep(1)
+            # Re-get the MAC value after random generation
+            test_mac = mac_field.get_attribute("value")
+        except Exception:
+            # Random button didn't work, enter manually
+            mac_field.clear()
+            mac_field.send_keys(random_mac)
+            test_mac = random_mac
+    else:
+        # No random button, enter manually
+        mac_field.clear()
+        mac_field.send_keys(random_mac)
+        test_mac = random_mac
+
+    assert len(test_mac) > 0, "MAC address should be filled"
+
+    # Look for IP field (optional)
+    ip_field = None
+    ip_selectors = ["input#ip", "input#deviceIP", "input#txtIP", "input[name='ip']", "input[placeholder*='IP' i]"]
+    for selector in ip_selectors:
+        try:
+            fields = driver.find_elements(By.CSS_SELECTOR, selector)
+            if len(fields) > 0 and fields[0].is_displayed():
+                ip_field = fields[0]
+                break
+        except Exception:
+            continue
+
+    if ip_field:
+        # Find and click "Generate Random IP" button if it exists
+        random_ip_buttons = driver.find_elements(By.CSS_SELECTOR, "button[onclick*='randomIP'], button[onclick*='generateIP'], #btnRandomIP")
+        if len(random_ip_buttons) > 0:
+            try:
+                driver.execute_script("arguments[0].click();", random_ip_buttons[0])
+                time.sleep(0.5)
+            except:
+                pass
+
+        # If IP is still empty, enter manually
+        if not ip_field.get_attribute("value"):
+            random_ip = f"192.168.1.{random.randint(100,250)}"
+            ip_field.clear()
+            ip_field.send_keys(random_ip)
+
+    # Fill in device name (optional)
+    name_field = None
+    name_selectors = ["input#name", "input#deviceName", "input#txtName", "input[name='name']", "input[placeholder*='Name' i]"]
+    for selector in name_selectors:
+        try:
+            fields = driver.find_elements(By.CSS_SELECTOR, selector)
+            if len(fields) > 0 and fields[0].is_displayed():
+                name_field = fields[0]
+                break
+        except:
+            continue
+
+    if name_field:
+        name_field.clear()
+        name_field.send_keys("Test Device Selenium")
+
+    # Find and click Save button
+    save_buttons = driver.find_elements(By.CSS_SELECTOR, "button#btnSave, button#save, button[type='submit'], button.btn-primary, button[onclick*='save' i]")
+    if len(save_buttons) == 0:
+        save_buttons = driver.find_elements(By.XPATH, "//button[contains(translate(text(), 'SAVE', 'save'), 'save')]")
+
+    if len(save_buttons) == 0:
+        # No save button found - skip test
+        assert True, "Save button not found - test incomplete"
+        return
+
+    # Click save
+    driver.execute_script("arguments[0].click();", save_buttons[0])
+    time.sleep(3)
+
+    # Verify device was saved via API
+    headers = {"Authorization": f"Bearer {api_token}"}
+    verify_response = requests.get(
+        f"{API_BASE_URL}/device/{test_mac}",
+        headers=headers
+    )
+
+    if verify_response.status_code == 200:
+        # Device was created successfully
+        device_data = verify_response.json()
+        assert device_data is not None, "Device should exist in database"
+
+        # Cleanup: Delete the test device
+        try:
+            delete_response = requests.delete(
+                f"{API_BASE_URL}/device/{test_mac}",
+                headers=headers
+            )
+        except:
+            pass  # Delete might not be supported
+    else:
+        # Check if device appears in the UI
+        driver.get(f"{BASE_URL}/devices.php")
+        time.sleep(2)
+
+        # If device is in page source, test passed even if API failed
+        if test_mac in driver.page_source or "Test Device Selenium" in driver.page_source:
+            assert True, "Device appears in UI"
+        else:
+            # Can't verify - just check that save didn't produce visible errors
+            # Look for actual error messages (not JavaScript code)
+            error_indicators = driver.find_elements(By.CSS_SELECTOR, ".alert-danger, .error-message, .callout-danger")
+            has_error = any(elem.is_displayed() and len(elem.text) > 0 for elem in error_indicators)
+            assert not has_error, "Save should not produce visible error messages"