Merge pull request #1468 from adamoutler/http_sec_fetch

Http sec fetch

test/api_endpoints/test_nginx_proxy_security.py

@@ -0,0 +1,141 @@
+import pytest
+import requests
+import os
+
+# Nginx listens on PORT, default 20211
+PORT = os.environ.get("PORT", "20211")
+BACKEND_PORT = os.environ.get("BACKEND_PORT", "20212")
+BASE_URL = f"http://localhost:{PORT}/server/"
+
+REQUEST_TIMEOUT = int(os.environ.get("REQUEST_TIMEOUT", 5))
+
+def http_get(url, headers=None):
+    return requests.get(url, headers=headers, timeout=REQUEST_TIMEOUT)
+
+
+def test_nginx_proxy_security_modern_check():
+    """
+    Test that access is allowed when Sec-Fetch-Site is 'same-origin'.
+    """
+    headers = {
+        "Sec-Fetch-Site": "same-origin"
+    }
+    try:
+        response = http_get(BASE_URL, headers=headers)
+        # 200 (OK), 401 (Auth), 404 (Not Found on backend), or 502 (Bad Gateway) means Nginx let it through.
+        # 403 means Nginx blocked it.
+        assert response.status_code in [200, 401, 404, 502], f"Expected access allowed, got {response.status_code}"
+    except requests.exceptions.ConnectionError:
+        pytest.fail("Could not connect to Nginx. Is it running?")
+
+
+def test_nginx_proxy_security_legacy_check():
+    """
+    Test that access is allowed when Sec-Fetch-Site is missing but Referer matches host.
+    This is for old tablets/phones which are not updated in the last few years.
+    """
+    headers = {
+        # No Sec-Fetch-Site
+        "Referer": f"http://localhost:{PORT}/some/page"
+    }
+    try:
+        response = http_get(BASE_URL, headers=headers)
+        assert response.status_code in [200, 401, 404, 502], f"Expected access allowed, got {response.status_code}"
+    except requests.exceptions.ConnectionError:
+        pytest.fail("Could not connect to Nginx. Is it running?")
+
+
+def test_nginx_proxy_security_block_cross_site():
+    """
+    Test that access is BLOCKED when Sec-Fetch-Site is 'cross-site'.
+    """
+    headers = {
+        "Sec-Fetch-Site": "cross-site"
+    }
+    response = http_get(BASE_URL, headers=headers)
+    assert response.status_code == 403, f"Expected 403 Forbidden, got {response.status_code}"
+
+
+def test_nginx_proxy_security_block_no_headers():
+    """
+    Test that access is BLOCKED when no security headers are present.
+    """
+    headers = {}
+    response = http_get(BASE_URL, headers=headers)
+    assert response.status_code == 403, f"Expected 403 Forbidden, got {response.status_code}"
+
+
+def test_nginx_proxy_security_block_same_site():
+    """
+    Test that access is BLOCKED when Sec-Fetch-Site is 'same-site'.
+    (Strict same-origin enforcement)
+    """
+    headers = {"Sec-Fetch-Site": "same-site"}
+    response = http_get(BASE_URL, headers=headers)
+    assert response.status_code == 403, f"Expected 403 for same-site, got {response.status_code}"
+
+
+def test_nginx_proxy_security_block_referer_suffix_spoof():
+    """
+    Test that access is BLOCKED when Referer merely ends with the valid host.
+    """
+    headers = {"Referer": f"http://attacker.com/path?target=localhost:{PORT}"}
+    response = http_get(BASE_URL, headers=headers)
+    assert response.status_code == 403
+
+
+def test_nginx_proxy_security_block_bad_referer():
+    """
+    Test that access is BLOCKED when Sec-Fetch-Site is missing and Referer is external.
+    """
+    headers = {
+        "Referer": "http://evil.com/page"
+    }
+    response = http_get(BASE_URL, headers=headers)
+    assert response.status_code == 403, f"Expected 403 Forbidden, got {response.status_code}"
+
+
+def test_nginx_proxy_security_block_subdomain_referer():
+    """
+    Test that access is BLOCKED when Referer is a subdomain (same-site, not same-origin).
+    """
+    headers = {
+        "Referer": f"http://subdomain.localhost:{PORT}/"
+    }
+    response = http_get(BASE_URL, headers=headers)
+    assert response.status_code == 403, f"Expected 403 for subdomain referer, got {response.status_code}"
+
+
+def test_nginx_proxy_security_legacy_protocol_agnostic():
+    """
+    Test that the legacy check allows both http and https referers.
+    """
+    headers = {"Referer": f"https://localhost:{PORT}/path"}
+    response = http_get(BASE_URL, headers=headers)
+    assert response.status_code in [200, 401, 404, 502]
+
+
+def test_nginx_proxy_security_block_server_docs():
+    """
+    Test that access to `/server/docs` is BLOCKED when navigating with browser (no referrer)
+    """
+    url = f"http://localhost:{PORT}/server/docs"
+    try:
+        response = http_get(url)
+        # Backend may return 404 if it doesn't have the path; Nginx should never allow a 200 here.
+        assert response.status_code == 403, f"Expected 403 for /server/docs, got {response.status_code}"
+    except requests.exceptions.ConnectionError:
+        pytest.fail("Could not connect to Nginx. Is it running?")
+
+
+def test_nginx_proxy_security_allow_port():
+    """
+    Test that access to `:20212/docs` is allowed by Nginx (should return 200).
+    """
+    headers = {"Referer": f"https://localhost:{BACKEND_PORT}/path"}
+    url = f"http://localhost:{BACKEND_PORT}/docs"
+    try:
+        response = http_get(url, headers=headers)
+        assert response.status_code == 200, f"Expected 200 for /server/docs on allowed port, got {response.status_code}"
+    except requests.exceptions.ConnectionError:
+        pytest.fail("Could not connect to Nginx. Is it running?")

test/docker_tests/run_docker_tests.sh

@@ -17,6 +17,9 @@ else
     echo "ERROR: generate-configs.sh not found. Aborting."
     exit 1
 fi
+echo "Development $(git rev-parse --short=8 HEAD)" |  tee ".VERSION" >/dev/null
+date +%s > front/buildtimestamp.txt
+
 
 # --- 2. Build the Docker Image ---
 echo "--- Building 'netalertx-dev-test' image ---"

test/docker_tests/test_docker_compose_scenarios.py

@@ -749,7 +749,7 @@ def test_custom_port_with_unwritable_nginx_config_compose() -> None:
     # Container should exit due to inability to write nginx config and custom port.
     assert result.returncode == 1
     assert "unable to write to /tmp/nginx/active-config/netalertx.conf" in lowered_output
-    assert "mv: can't create '/tmp/nginx/active-config/nginx.conf'" in lowered_output
+
 
 
 def test_host_network_compose(tmp_path: pathlib.Path) -> None: