From b0c687a1717e4ba8ca567aea4a863c9313e52e13 Mon Sep 17 00:00:00 2001
From: "Jokob @NetAlertX" <96159884+jokob-sk@users.noreply.github.com>
Date: Sun, 12 Apr 2026 22:28:53 +0000
Subject: [PATCH] PLG: Add 'No Data' message for empty plugin tabs and enhance
 event data loading checks #1607

---
 front/deviceDetailsEvents.php           | 13 ++++++++++++-
 front/php/templates/language/ar_ar.json |  3 ++-
 front/php/templates/language/ca_ca.json |  3 ++-
 front/php/templates/language/cs_cz.json |  1 +
 front/php/templates/language/de_de.json |  3 ++-
 front/php/templates/language/en_us.json |  1 +
 front/php/templates/language/es_es.json |  3 ++-
 front/php/templates/language/fa_fa.json |  1 +
 front/php/templates/language/fi_fi.json |  1 +
 front/php/templates/language/fr_fr.json |  3 ++-
 front/php/templates/language/he_il.json |  1 +
 front/php/templates/language/id_id.json |  1 +
 front/php/templates/language/it_it.json |  3 ++-
 front/php/templates/language/ja_jp.json |  3 ++-
 front/php/templates/language/nb_no.json |  1 +
 front/php/templates/language/pl_pl.json |  3 ++-
 front/php/templates/language/pt_br.json |  3 ++-
 front/php/templates/language/pt_pt.json |  3 ++-
 front/php/templates/language/ru_ru.json |  3 ++-
 front/php/templates/language/sv_sv.json |  1 +
 front/php/templates/language/tr_tr.json |  3 ++-
 front/php/templates/language/uk_ua.json |  3 ++-
 front/php/templates/language/vi_vn.json |  1 +
 front/php/templates/language/zh_cn.json |  3 ++-
 front/pluginsCore.php                   |  6 ++++++
 25 files changed, 55 insertions(+), 15 deletions(-)

diff --git a/front/deviceDetailsEvents.php b/front/deviceDetailsEvents.php
index 87a29885..e747b1c1 100755
--- a/front/deviceDetailsEvents.php
+++ b/front/deviceDetailsEvents.php
@@ -31,6 +31,12 @@
 <script>
 
 function loadEventsData() {
+  const mac = getMac();
+  if (!mac) {
+    console.warn("loadEventsData: mac not set, skipping");
+    return;
+  }
+
   const hideConnections = $('#chkHideConnectionEvents')[0].checked;
 
   let period = $("#period").val();
@@ -65,7 +71,7 @@ function loadEventsData() {
       query,
       variables: {
         options: {
-          eveMac:   mac,
+          eveMac:   mac,  // local const from getMac() above
           dateFrom: start,
           dateTo:   end,
           limit:    500,
@@ -163,6 +169,11 @@ function initDeviceEventsPage()
     return; // exit early if nothing is visible
   }
 
+  // Only proceed if mac is available
+  if (!getMac()) {
+    return; // exit early if mac is not yet set
+  }
+
   // init page once
   if (eventsPageInitialized) return; //  ENSURE ONCE
   eventsPageInitialized = true;
diff --git a/front/php/templates/language/ar_ar.json b/front/php/templates/language/ar_ar.json
index d31b984a..ce2c624b 100644
--- a/front/php/templates/language/ar_ar.json
+++ b/front/php/templates/language/ar_ar.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "قاعدة البيانات مقفلة",
     "Gen_NetworkMask": "قناع الشبكة",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "غير متصل",
     "Gen_Okay": "موافق",
     "Gen_Online": "متصل",
@@ -805,4 +806,4 @@
     "settings_system_label": "نظام",
     "settings_update_item_warning": "قم بتحديث القيمة أدناه. احرص على اتباع التنسيق السابق. <b>لم يتم إجراء التحقق.</b>",
     "test_event_tooltip": "احفظ التغييرات أولاً قبل اختبار الإعدادات."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/ca_ca.json b/front/php/templates/language/ca_ca.json
index 32d51d3d..bb989bc1 100644
--- a/front/php/templates/language/ca_ca.json
+++ b/front/php/templates/language/ca_ca.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "ERROR - DB podria estar bloquejada - Fes servir F12 Eines desenvolupament -> Consola o provar-ho més tard.",
     "Gen_NetworkMask": "Màscara de xarxa",
     "Gen_New": "Nou",
+    "Gen_No_Data": "",
     "Gen_Offline": "Fora de línia",
     "Gen_Okay": "Ok",
     "Gen_Online": "En línia",
@@ -805,4 +806,4 @@
     "settings_system_label": "Sistema",
     "settings_update_item_warning": "Actualitza el valor sota. Sigues curós de seguir el format anterior. <b>No hi ha validació.</b>",
     "test_event_tooltip": "Deseu els canvis primer abans de comprovar la configuració."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/cs_cz.json b/front/php/templates/language/cs_cz.json
index 4627c5e2..51254acf 100644
--- a/front/php/templates/language/cs_cz.json
+++ b/front/php/templates/language/cs_cz.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "CHYBA - Databáze je možná zamčená - Zkontrolujte F12 -> Nástroje pro vývojáře -> Konzole. nebo to zkuste později.",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "Offline",
     "Gen_Okay": "Ok",
     "Gen_Online": "Online",
diff --git a/front/php/templates/language/de_de.json b/front/php/templates/language/de_de.json
index 30a80045..1f98c9ec 100644
--- a/front/php/templates/language/de_de.json
+++ b/front/php/templates/language/de_de.json
@@ -348,6 +348,7 @@
     "Gen_LockedDB": "ERROR - DB eventuell gesperrt - Nutze die Konsole in den Entwickler Werkzeugen (F12) zur Überprüfung oder probiere es später erneut.",
     "Gen_NetworkMask": "Netzmaske",
     "Gen_New": "Neu",
+    "Gen_No_Data": "",
     "Gen_Offline": "Offline",
     "Gen_Okay": "Ok",
     "Gen_Online": "Online",
@@ -878,4 +879,4 @@
     "settings_system_label": "System",
     "settings_update_item_warning": "",
     "test_event_tooltip": "Speichere die Änderungen, bevor Sie die Einstellungen testen."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/en_us.json b/front/php/templates/language/en_us.json
index 155b331e..d5ab0b73 100755
--- a/front/php/templates/language/en_us.json
+++ b/front/php/templates/language/en_us.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "ERROR - DB might be locked - Check F12 Dev tools -> Console or try later.",
     "Gen_NetworkMask": "Network mask",
     "Gen_New": "New",
+    "Gen_No_Data": "No data",
     "Gen_Offline": "Offline",
     "Gen_Okay": "Ok",
     "Gen_Online": "Online",
diff --git a/front/php/templates/language/es_es.json b/front/php/templates/language/es_es.json
index 5c903a70..ff9c8bd8 100644
--- a/front/php/templates/language/es_es.json
+++ b/front/php/templates/language/es_es.json
@@ -346,6 +346,7 @@
     "Gen_LockedDB": "Fallo - La base de datos puede estar bloqueada - Pulsa F1 -> Ajustes de desarrolladores -> Consola o prueba más tarde.",
     "Gen_NetworkMask": "Máscara de red",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "Desconectado",
     "Gen_Okay": "Aceptar",
     "Gen_Online": "En linea",
@@ -876,4 +877,4 @@
     "settings_system_label": "Sistema",
     "settings_update_item_warning": "Actualice el valor a continuación. Tenga cuidado de seguir el formato anterior. <b>O la validación no se realiza.</b>",
     "test_event_tooltip": "Guarda tus cambios antes de probar nuevos ajustes."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/fa_fa.json b/front/php/templates/language/fa_fa.json
index 577ab676..0998caec 100644
--- a/front/php/templates/language/fa_fa.json
+++ b/front/php/templates/language/fa_fa.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "",
     "Gen_Okay": "",
     "Gen_Online": "",
diff --git a/front/php/templates/language/fi_fi.json b/front/php/templates/language/fi_fi.json
index 9bff957a..063de1d5 100644
--- a/front/php/templates/language/fi_fi.json
+++ b/front/php/templates/language/fi_fi.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "",
     "Gen_Okay": "",
     "Gen_Online": "",
diff --git a/front/php/templates/language/fr_fr.json b/front/php/templates/language/fr_fr.json
index 601446c0..c7fc9079 100644
--- a/front/php/templates/language/fr_fr.json
+++ b/front/php/templates/language/fr_fr.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "Erreur - La base de données est peut-être verrouillée - Vérifier avec les outils de dév via F12 -> Console ou essayer plus tard.",
     "Gen_NetworkMask": "Masque réseau",
     "Gen_New": "Nouveau",
+    "Gen_No_Data": "",
     "Gen_Offline": "Hors ligne",
     "Gen_Okay": "OK",
     "Gen_Online": "En ligne",
@@ -805,4 +806,4 @@
     "settings_system_label": "Système",
     "settings_update_item_warning": "Mettre à jour la valeur ci-dessous. Veillez à bien suivre le même format qu'auparavant. <b>Il n'y a pas de pas de contrôle.</b>",
     "test_event_tooltip": "Enregistrer d'abord vos modifications avant de tester vôtre paramétrage."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/he_il.json b/front/php/templates/language/he_il.json
index 9bff957a..063de1d5 100644
--- a/front/php/templates/language/he_il.json
+++ b/front/php/templates/language/he_il.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "",
     "Gen_Okay": "",
     "Gen_Online": "",
diff --git a/front/php/templates/language/id_id.json b/front/php/templates/language/id_id.json
index 9bff957a..063de1d5 100644
--- a/front/php/templates/language/id_id.json
+++ b/front/php/templates/language/id_id.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "",
     "Gen_Okay": "",
     "Gen_Online": "",
diff --git a/front/php/templates/language/it_it.json b/front/php/templates/language/it_it.json
index e6f453b3..c58c5195 100644
--- a/front/php/templates/language/it_it.json
+++ b/front/php/templates/language/it_it.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "ERRORE: il DB potrebbe essere bloccato, controlla F12 Strumenti di sviluppo -> Console o riprova più tardi.",
     "Gen_NetworkMask": "Maschera di rete",
     "Gen_New": "Nuovo",
+    "Gen_No_Data": "",
     "Gen_Offline": "Offline",
     "Gen_Okay": "Ok",
     "Gen_Online": "Online",
@@ -805,4 +806,4 @@
     "settings_system_label": "Sistema",
     "settings_update_item_warning": "Aggiorna il valore qui sotto. Fai attenzione a seguire il formato precedente. <b>La convalida non viene eseguita.</b>",
     "test_event_tooltip": "Salva le modifiche prima di provare le nuove impostazioni."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/ja_jp.json b/front/php/templates/language/ja_jp.json
index 43f2a891..b65afe06 100644
--- a/front/php/templates/language/ja_jp.json
+++ b/front/php/templates/language/ja_jp.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "エラー - DBがロックされている可能性があります - F12で開発者ツール→コンソールを確認するか、後で試してください。",
     "Gen_NetworkMask": "ネットワークマスク",
     "Gen_New": "New",
+    "Gen_No_Data": "",
     "Gen_Offline": "オフライン",
     "Gen_Okay": "Ok",
     "Gen_Online": "オンライン",
@@ -805,4 +806,4 @@
     "settings_system_label": "システム",
     "settings_update_item_warning": "以下の値を更新してください。以前のフォーマットに従うよう注意してください。<b>検証は行われません。</b>",
     "test_event_tooltip": "設定をテストする前に、まず変更を保存してください。"
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/nb_no.json b/front/php/templates/language/nb_no.json
index 504732b6..31cc8b7f 100644
--- a/front/php/templates/language/nb_no.json
+++ b/front/php/templates/language/nb_no.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "FEIL - DB kan være låst - Sjekk F12 Dev tools -> Konsoll eller prøv senere.",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "Frakoblet",
     "Gen_Okay": "Ok",
     "Gen_Online": "",
diff --git a/front/php/templates/language/pl_pl.json b/front/php/templates/language/pl_pl.json
index d62158d2..9503b515 100644
--- a/front/php/templates/language/pl_pl.json
+++ b/front/php/templates/language/pl_pl.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "Błąd - Baza danych może być zablokowana - Sprawdź narzędzia deweloperskie F12 -> Konsola lub spróbuj później.",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "Niedostępne",
     "Gen_Okay": "Ok",
     "Gen_Online": "Dostępne",
@@ -805,4 +806,4 @@
     "settings_system_label": "System",
     "settings_update_item_warning": "Zaktualizuj wartość poniżej. Uważaj, aby zachować poprzedni format. <b>Walidacja nie jest wykonywana.</b>",
     "test_event_tooltip": "Najpierw zapisz swoje zmiany, zanim przetestujesz ustawienia."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/pt_br.json b/front/php/templates/language/pt_br.json
index 56b33dab..c47e6627 100644
--- a/front/php/templates/language/pt_br.json
+++ b/front/php/templates/language/pt_br.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "ERRO - O banco de dados pode estar bloqueado - Verifique F12 Ferramentas de desenvolvimento -> Console ou tente mais tarde.",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "Offline",
     "Gen_Okay": "Ok",
     "Gen_Online": "Online",
@@ -805,4 +806,4 @@
     "settings_system_label": "",
     "settings_update_item_warning": "",
     "test_event_tooltip": "Guarde as alterações antes de testar as definições."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/pt_pt.json b/front/php/templates/language/pt_pt.json
index 5d5c8579..c46db11e 100644
--- a/front/php/templates/language/pt_pt.json
+++ b/front/php/templates/language/pt_pt.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "ERRO - A base de dados pode estar bloqueada - Verifique F12 Ferramentas de desenvolvimento -> Console ou tente mais tarde.",
     "Gen_NetworkMask": "Máscara de Rede",
     "Gen_New": "Novo",
+    "Gen_No_Data": "",
     "Gen_Offline": "Offline",
     "Gen_Okay": "Ok",
     "Gen_Online": "Online",
@@ -805,4 +806,4 @@
     "settings_system_label": "",
     "settings_update_item_warning": "",
     "test_event_tooltip": "Guarde as alterações antes de testar as definições."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/ru_ru.json b/front/php/templates/language/ru_ru.json
index 502f2a29..dc490cfd 100644
--- a/front/php/templates/language/ru_ru.json
+++ b/front/php/templates/language/ru_ru.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "ОШИБКА - Возможно, база данных заблокирована. Проверьте инструменты разработчика F12 -> Консоль или повторите попытку позже.",
     "Gen_NetworkMask": "Маска сети",
     "Gen_New": "Новый",
+    "Gen_No_Data": "",
     "Gen_Offline": "Оффлайн",
     "Gen_Okay": "OK",
     "Gen_Online": "Онлайн",
@@ -805,4 +806,4 @@
     "settings_system_label": "Система",
     "settings_update_item_warning": "Обновить значение ниже. Будьте осторожны, следуя предыдущему формату. <b>Проверка не выполняется.</b>",
     "test_event_tooltip": "Сначала сохраните изменения, прежде чем проверять настройки."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/sv_sv.json b/front/php/templates/language/sv_sv.json
index 9bff957a..063de1d5 100644
--- a/front/php/templates/language/sv_sv.json
+++ b/front/php/templates/language/sv_sv.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "",
     "Gen_Okay": "",
     "Gen_Online": "",
diff --git a/front/php/templates/language/tr_tr.json b/front/php/templates/language/tr_tr.json
index 64bfcc65..606c7660 100644
--- a/front/php/templates/language/tr_tr.json
+++ b/front/php/templates/language/tr_tr.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "HATA - Veritabanı kilitlenmiş olabilir - F12 Geliştirici araçlarını -> Konsol kısmını kontrol edin veya daha sonra tekrar deneyin.",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "Çevrimdışı",
     "Gen_Okay": "Tamam",
     "Gen_Online": "Çevrimiçi",
@@ -805,4 +806,4 @@
     "settings_system_label": "Sistem",
     "settings_update_item_warning": "",
     "test_event_tooltip": ""
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/uk_ua.json b/front/php/templates/language/uk_ua.json
index c6fd4bf4..e128efdd 100644
--- a/front/php/templates/language/uk_ua.json
+++ b/front/php/templates/language/uk_ua.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "ПОМИЛКА – БД може бути заблоковано – перевірте F12 Інструменти розробника -> Консоль або спробуйте пізніше.",
     "Gen_NetworkMask": "Маска мережі",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "Офлайн",
     "Gen_Okay": "Гаразд",
     "Gen_Online": "Онлайн",
@@ -805,4 +806,4 @@
     "settings_system_label": "Система",
     "settings_update_item_warning": "Оновіть значення нижче. Слідкуйте за попереднім форматом. <b>Перевірка не виконана.</b>",
     "test_event_tooltip": "Перш ніж перевіряти налаштування, збережіть зміни."
-}
+}
\ No newline at end of file
diff --git a/front/php/templates/language/vi_vn.json b/front/php/templates/language/vi_vn.json
index 9bff957a..063de1d5 100644
--- a/front/php/templates/language/vi_vn.json
+++ b/front/php/templates/language/vi_vn.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "",
     "Gen_NetworkMask": "",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "",
     "Gen_Okay": "",
     "Gen_Online": "",
diff --git a/front/php/templates/language/zh_cn.json b/front/php/templates/language/zh_cn.json
index 1c339420..ecc2398e 100644
--- a/front/php/templates/language/zh_cn.json
+++ b/front/php/templates/language/zh_cn.json
@@ -344,6 +344,7 @@
     "Gen_LockedDB": "错误 - DB 可能被锁定 - 检查 F12 开发工具 -> 控制台或稍后重试。",
     "Gen_NetworkMask": "网络掩码",
     "Gen_New": "",
+    "Gen_No_Data": "",
     "Gen_Offline": "离线",
     "Gen_Okay": "Ok",
     "Gen_Online": "在线",
@@ -805,4 +806,4 @@
     "settings_system_label": "系统",
     "settings_update_item_warning": "更新下面的值。请注意遵循先前的格式。<b>未执行验证。</b>",
     "test_event_tooltip": "在测试设置之前，请先保存更改。"
-}
+}
\ No newline at end of file
diff --git a/front/pluginsCore.php b/front/pluginsCore.php
index 868a36d7..e2b6e0ea 100755
--- a/front/pluginsCore.php
+++ b/front/pluginsCore.php
@@ -513,6 +513,12 @@ function generateTabs() {
     }
   });
 
+  if (visiblePlugins.length === 0) {
+    $('#tabs-content-location').html(`<p class="text-muted" style="padding: 15px;">${getString('Gen_No_Data')}</p>`);
+    hideSpinner();
+    return;
+  }
+
   // Auto-select tab from ?tab= URL param or cache (scoped to plugin nav only)
   initializeTabsShared({
     cacheKey:      'activePluginsTab',