Coderabit suggestions

install/production-filesystem/services/check-app.sh

@@ -1,7 +0,0 @@
-#!/bin/sh
-# app-check.sh - Ensures /app/api/table_settings.json exists
-
-if [ ! -f /app/api/table_settings.json ]; then
-    # mkdir -p /app/api
-    # echo -ne '{}' > /app/api/table_settings.json
-fi

install/production-filesystem/services/start-backend.sh

@@ -1,10 +1,15 @@
 #!/bin/bash
 
 cd "${NETALERTX_APP}" || exit 1
-while $(ps ax | grep -v grep | grep python3 >/dev/null); do
-	killall python3 &>/dev/null
+max_attempts=50  # 10 seconds total (50 * 0.2s)
+attempt=0
+while ps ax | grep -v grep | grep -q python3 && [ $attempt -lt $max_attempts ]; do
+	killall -TERM python3 &>/dev/null
 	sleep 0.2
+	((attempt++))
 done
+# Force kill if graceful shutdown failed
+killall -KILL python3 &>/dev/null
 
 echo "python3 $(cat /services/config/python/backend-extra-launch-parameters 2>/dev/null) -m server > >(tee /app/log/stdout.log) 2> >(tee /app/log/stderr.log >&2)"
 exec python3 $(cat /services/config/python/backend-extra-launch-parameters 2>/dev/null) -m server > >(tee /app/log/stdout.log) 2> >(tee /app/log/stderr.log >&2)

install/production-filesystem/services/start-crond.sh

@@ -16,7 +16,7 @@ forward_signal() {
 	fi
 }
 
-while $(ps ax | grep -v -e grep -e '.sh' | grep crond >/dev/null); do
+while ps ax | grep -v -e grep -e '.sh' | grep crond >/dev/null 2>&1; do
 	killall crond &>/dev/null
 	sleep 0.2
 done

install/production-filesystem/services/start-php-fpm.sh

@@ -16,7 +16,7 @@ forward_signal() {
 	fi
 }
 
-while $(ps ax | grep -v grep | grep php-fpm83 >/dev/null); do
+while ps ax | grep -v grep | grep php-fpm83 >/dev/null; do
 	killall php-fpm83 &>/dev/null
 	sleep 0.2
 done