vh/NetAlertX
1
0
Fork 0
mirror of https://github.com/jokob-sk/NetAlertX.git synced 2026-04-11 20:51:41 -07:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Coderabbit requested fixes.

Browse Source
This commit is contained in:
Adam Outler
2025-12-21 20:18:59 +00:00
parent 492c6e3883
commit 24c806005f
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.devcontainer/Dockerfile
View File

@@ -9,7 +9,7 @@
# #
# Stage 2. Runner builds the bare minimum requirements to create an operational NetAlertX. The primary # Stage 2. Runner builds the bare minimum requirements to create an operational NetAlertX. The primary
# reason for breaking at this stage is it leaves the system in a proper state for devcontainer operation # reason for breaking at this stage is it leaves the system in a proper state for devcontainer operation
# This image also provides a break-out point for users who wish to execute the anti-pattern of using a # This image also provides a break-out point for uses who wish to execute the anti-pattern of using a
# docker container as a VM for experimentation and various development patterns. # docker container as a VM for experimentation and various development patterns.
# #
# Stage 3. Hardened removes root, sudoers, folders, permissions, and locks the system down into a read-only # Stage 3. Hardened removes root, sudoers, folders, permissions, and locks the system down into a read-only

5
test/docker_tests/test_container_environment.py
View File

@@ -1184,9 +1184,6 @@ def test_restrictive_permissions_handling(tmp_path: pathlib.Path) -> None:
_assert_contains(result_root, "NetAlertX is running as ROOT", result_root.args) _assert_contains(result_root, "NetAlertX is running as ROOT", result_root.args)
_assert_contains(result_root, "Permissions fixed for read-write paths", result_root.args) _assert_contains(result_root, "Permissions fixed for read-write paths", result_root.args)
# Verify the fix actually happened
data_host_path = paths["data"]
check_cmd = [ check_cmd = [
"docker", "run", "--rm", "docker", "run", "--rm",
"--entrypoint", "/bin/sh", "--entrypoint", "/bin/sh",
@@ -1195,7 +1192,7 @@ def test_restrictive_permissions_handling(tmp_path: pathlib.Path) -> None:
"-c", "ls -ldn /data/db && touch /data/db/test_write_after_fix" "-c", "ls -ldn /data/db && touch /data/db/test_write_after_fix"
] ]
# Add all volumes to check_cmd too # Add all volumes to check_cmd too
for host_path, target, readonly in volumes: for host_path, target, _readonly in volumes:
check_cmd.extend(["-v", f"{host_path}:{target}"]) check_cmd.extend(["-v", f"{host_path}:{target}"])
check_result = subprocess.run( check_result = subprocess.run(