BE+FE: work on bulk deleting devices and code cleanup #1493

Signed-off-by: jokob-sk <jokob.sk@gmail.com>
This commit is contained in:
jokob-sk
2026-02-07 10:37:31 +11:00
parent 6bc2de6e24
commit 0ce4e5f70c
8 changed files with 41 additions and 60 deletions

View File

@@ -638,20 +638,17 @@ def api_get_devices(payload=None):
@app.route("/devices", methods=["DELETE"])
@validate_request(
operation_id="delete_devices",
summary="Delete Multiple Devices",
description="Delete multiple devices by MAC address.",
summary="Delete Devices (Bulk / All)",
description="Delete devices by MAC address. Provide a list of MACs to delete specific devices, set confirm_delete_all=true with an empty macs list to delete ALL devices. Supports wildcard '*' matching.",
request_model=DeleteDevicesRequest,
tags=["devices"],
auth_callable=is_authorized
)
def api_devices_delete(payload=None):
data = request.get_json(silent=True) or {}
macs = data.get('macs', [])
if not macs:
return jsonify({"success": False, "message": "ERROR: Missing parameters", "error": "macs list is required"}), 400
def api_devices_delete(payload: DeleteDevicesRequest = None):
device_handler = DeviceInstance()
macs = None if payload.confirm_delete_all else payload.macs
return jsonify(device_handler.deleteDevices(macs))

View File

@@ -444,8 +444,27 @@ class DeviceUpdateRequest(BaseModel):
class DeleteDevicesRequest(BaseModel):
"""Request to delete multiple devices."""
macs: List[str] = Field([], description="List of MACs to delete")
confirm_delete_all: bool = Field(False, description="Explicit flag to delete ALL devices when macs is empty")
macs: List[str] = Field(
default_factory=list,
description="List of MACs to delete (supports '*' wildcard at the end or start for individual macs)"
)
confirm_delete_all: bool = Field(
default=False,
description="Explicit flag to delete ALL devices when macs is empty"
)
model_config = {
"json_schema_extra": {
"examples": [
{
"summary": "Delete specific devices",
"value": {
"macs": ["AA:BB:CC:DD:EE:FF", "AA:BB:CC:DD:*"],
"confirm_delete_all": False
}
}
]
}
}
@field_validator("macs")
@classmethod
@@ -453,9 +472,11 @@ class DeleteDevicesRequest(BaseModel):
return [validate_mac(mac) for mac in v]
@model_validator(mode="after")
def check_delete_all_safety(self) -> DeleteDevicesRequest:
def check_delete_all_safety(self):
if not self.macs and not self.confirm_delete_all:
raise ValueError("Must provide at least one MAC or set confirm_delete_all=True")
raise ValueError(
"Must provide at least one MAC or set confirm_delete_all=True"
)
return self